Skip to content

separated nested argument lists to avoid an error when compiling with…#65

Merged
aothms merged 1 commit into
IfcOpenShell:masterfrom
iras:nested_argument_list_bug
May 5, 2016
Merged

separated nested argument lists to avoid an error when compiling with…#65
aothms merged 1 commit into
IfcOpenShell:masterfrom
iras:nested_argument_list_bug

Conversation

@iras

@iras iras commented May 5, 2016

Copy link
Copy Markdown
Contributor

… gcc.

@aothms

aothms commented May 5, 2016

Copy link
Copy Markdown
Member

Thanks, yeah, it's unfortunate that this doesn't result in an error in MS Visual Studio. Automated builds will help spot these issues in the future.

@aothms aothms merged commit 3f5d30f into IfcOpenShell:master May 5, 2016
@iras iras deleted the nested_argument_list_bug branch May 5, 2016 09:10
@Stinkfist0

Stinkfist0 commented May 5, 2016

Copy link
Copy Markdown
Contributor

BTW this syntax is valid C++11 syntax and newer GCC should compile this AFAIK.

@aothms

aothms commented May 5, 2016

Copy link
Copy Markdown
Member

But then you would need to compile with -std=c++11 which we do not do (thusfar).

@Stinkfist0

Stinkfist0 commented May 5, 2016

Copy link
Copy Markdown
Contributor

Yup, just an observation. Though I think GCC 5 defaults to 11 and some later versions to 14 already. In any case, it's good to have someone building with 03 conformance until we move to 11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants