Skip to content

Settings factory#827

Merged
Moult merged 1 commit into
IfcOpenShell:v0.6.0from
s-leger:patch-1
Apr 8, 2020
Merged

Settings factory#827
Moult merged 1 commit into
IfcOpenShell:v0.6.0from
s-leger:patch-1

Conversation

@s-leger

@s-leger s-leger commented Apr 8, 2020

Copy link
Copy Markdown
Contributor

Use a static "factory" method to keep init logic near settings definition.

logger = logging.getLogger('ExportIFC')
            logging.basicConfig(
                filename=context.scene.BIMProperties.data_dir + 'process.log',
                filemode='a', level=logging.DEBUG)
            output_file = bpy.path.ensure_ext(self.filepath, '.ifc')
            ifc_export_settings = export_ifc.IfcExportSettings.factory(context, output_file, logger)
            ifc_parser = export_ifc.IfcParser(ifc_export_settings)
            ifc_export_settings.logger.info('Starting export')

Use a static "factory" method to keep init logic near settings definition.
```python
logger = logging.getLogger('ExportIFC')
            logging.basicConfig(
                filename=context.scene.BIMProperties.data_dir + 'process.log',
                filemode='a', level=logging.DEBUG)
            output_file = bpy.path.ensure_ext(self.filepath, '.ifc')
            ifc_export_settings = export_ifc.IfcExportSettings.factory(context, output_file, logger)
            ifc_parser = export_ifc.IfcParser(ifc_export_settings)
            ifc_export_settings.logger.info('Starting export')
```
@s-leger

s-leger commented Apr 8, 2020

Copy link
Copy Markdown
Contributor Author

Use a static factory method for ifcExportSettings

@Moult Moult merged commit 79b7412 into IfcOpenShell:v0.6.0 Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants