MSYS build scripts and instructions by Stinkfist0 · Pull Request #99 · IfcOpenShell/IfcOpenShell

Stinkfist0 · 2016-07-02T23:09:15Z

Opening up for an initial review; a commit or two probably pending.

iras · 2016-07-04T06:41:02Z

Stinkfist0 · 2016-07-04T20:40:02Z

Closes #98 also

aothms · 2016-07-08T05:15:43Z

    find_package(Threads)
-    if (NOT APPLE)
-        set(LIB_RT "rt")
+    # TODO why OPENCASCADE_LIBRARIES is repeated three times below?


This is to resolve cyclic dependencies in gcc/ld. Better way seems to use --start-group ... --end-group, but didn't want to spend effort on it.

aothms · 2016-07-08T05:18:53Z

This is great thanks. Are there more commits pending? Don't really have the opportunity to test the changes, but they all look perfectly reasonable and since the bulk comprises build script additions, I am fine with merging as is.

Stinkfist0 · 2016-07-08T09:12:40Z

I'm having missing symbols errors for IfcPython build (Python is found successfully though - any tips?), but other than that this should be good to go.

iras · 2016-07-08T09:40:33Z

Most of the warnings have gone when compiling in gcc. As @Stinkfist0 already pointed out there are some warnings re Python plus a few others singled out below here.

[ 27%] Building CXX object CMakeFiles/IfcParse.dir/home/i/git/IfcOpenShell-2/src/ifcparse/IfcHierarchyHelper.cpp.o /home/i/git/IfcOpenShell-2/src/ifcparse/Ifc2x3-latebound.cpp: In function ‘void InitDescriptorMap()’: /home/i/git/IfcOpenShell-2/src/ifcparse/Ifc2x3-latebound.cpp:2426:31: warning: variable ‘current_enum’ set but not used [-Wunused-but-set-variable] IfcEnumerationDescriptor* current_enum; ^

[ 33%] Building CXX object CMakeFiles/IfcParse.dir/home/i/git/IfcOpenShell-2/src/ifcparse/Ifc2x3.cpp.o /home/i/git/IfcOpenShell-2/src/ifcparse/IfcParse.cpp: In member function ‘IfcUtil::IfcBaseClass* IfcParse::IfcFile::addEntity(IfcUtil::IfcBaseClass*)’: /home/i/git/IfcOpenShell-2/src/ifcparse/IfcParse.cpp:1255:34: warning: ‘*((void*)& conversion_factor +8)’ may be used uninitialized in this function [-Wmaybe-uninitialized] (*it) *= *conversion_factor; ^ Linking CXX static library libIfcParse.a

[ 97%] Building CXX object ifcwrap/CMakeFiles/_ifcopenshell_wrapper.dir/IfcPythonPYTHON_wrap.cxx.o /home/i/git/IfcOpenShell-2/src/ifcgeomserver/IfcGeomServer.cpp: In instantiation of ‘T sread(std::istream&) [with T = int; std::istream = std::basic_istream<char>]’: /home/i/git/IfcOpenShell-2/src/ifcgeomserver/IfcGeomServer.cpp:58:32: required from here /home/i/git/IfcOpenShell-2/src/ifcgeomserver/IfcGeomServer.cpp:53:18: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] return *((T*)buf); ^ /home/i/git/IfcOpenShell-2/src/ifcgeomserver/IfcGeomServer.cpp: In instantiation of ‘T sread(std::istream&) [with T = double; std::istream = std::basic_istream<char>]’: /home/i/git/IfcOpenShell-2/src/ifcgeomserver/IfcGeomServer.cpp:299:32: required from here /home/i/git/IfcOpenShell-2/src/ifcgeomserver/IfcGeomServer.cpp:53:18: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] /home/i/git/IfcOpenShell-2/src/ifcgeomserver/IfcGeomServer.cpp: In instantiation of ‘T sread(std::istream&) [with T = unsigned int; std::istream = std::basic_istream<char>]’: /home/i/git/IfcOpenShell-2/src/ifcgeomserver/IfcGeomServer.cpp:315:26: required from here /home/i/git/IfcOpenShell-2/src/ifcgeomserver/IfcGeomServer.cpp:53:18: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]

[100%] Built target IfcGeomServer /home/i/git/IfcOpenShell-2/src/ifcconvert/IfcConvert.cpp: In function ‘int main(int, char**)’: /home/i/git/IfcOpenShell-2/src/ifcconvert/IfcConvert.cpp:407:108: warning: ‘*((void*)& bounding_height +4)’ may be used uninitialized in this function [-Wmaybe-uninitialized] static_cast<SvgSerializer*>(serializer)->setBoundingRectangle(*bounding_width, *bounding_height); ^ /home/i/git/IfcOpenShell-2/src/ifcconvert/IfcConvert.cpp:407:108: warning: ‘*((void*)& bounding_width +4)’ may be used uninitialized in this function [-Wmaybe-uninitialized] Linking CXX executable IfcConvert

Stinkfist0 · 2016-07-08T14:28:25Z

Yeah couple warnings left, I could maybe take a look of them now. E: or not... Trying these build scripts now using a clean MSYS2 installation at the office and OCE build fails at the very end:
g++.exe: error: CreateProcess: No such file or directory
E: forgot to pacman -Sy pacman, maybe that's the reason.

…set and not used for anything ever

…tructs. Also prevent passing of negative values for --bounds.

Stinkfist0 · 2016-07-10T16:41:40Z

Only GCC warning left (with the current warning level) should be dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] in IfcGeomServer.cpp, but I'll leave that for Thomas, as I don't want to fix it bindly (I don't have any experience in running and testing IfcGeomServer myself).

iras · 2016-07-11T11:05:09Z

Cool. Thank you @Stinkfist0. I recompiled it with gcc and I can confirm the only warning left is the one thrown by IfcGeomServer.cpp.

[ 86%] Building CXX object CMakeFiles/IfcGeomServer.dir/home/i/git/IfcTest/src/ifcgeomserver/IfcGeomServer.cpp.o /home/i/git/IfcTest/src/ifcgeomserver/IfcGeomServer.cpp: In instantiation of ‘T sread(std::istream&) [with T = int; std::istream = std::basic_istream<char>]’: /home/i/git/IfcTest/src/ifcgeomserver/IfcGeomServer.cpp:58:32: required from here /home/i/git/IfcTest/src/ifcgeomserver/IfcGeomServer.cpp:53:18: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] return *((T*)buf); ^ /home/i/git/IfcTest/src/ifcgeomserver/IfcGeomServer.cpp: In instantiation of ‘T sread(std::istream&) [with T = double; std::istream = std::basic_istream<char>]’: /home/i/git/IfcTest/src/ifcgeomserver/IfcGeomServer.cpp:299:32: required from here /home/i/git/IfcTest/src/ifcgeomserver/IfcGeomServer.cpp:53:18: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] /home/i/git/IfcTest/src/ifcgeomserver/IfcGeomServer.cpp: In instantiation of ‘T sread(std::istream&) [with T = unsigned int; std::istream = std::basic_istream<char>]’: /home/i/git/IfcTest/src/ifcgeomserver/IfcGeomServer.cpp:315:26: required from here /home/i/git/IfcTest/src/ifcgeomserver/IfcGeomServer.cpp:53:18: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]

Thumbs up from me if you want to merge it @aothms.

aothms · 2016-07-15T03:48:44Z

Wonderful. I am still travelling, no time to check in detail, but looks good to me. Many many thanks.

Stinkfist0 · 2016-07-21T13:44:32Z

-		message(STATUS "ENABLE_BUILD_OPTIMIZATIONS not implemented for GCC/non-MSVC compilers.)")
+        # GCC-like: Release should use O3 but RelWithDebInfo 02 so enforce 03. Anything other useful that could be added here?
+        set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -O3")
+        set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "${CMAKE_CXX_FLAGS_RELEASE} -O3")


Could also experiment with -flto and -fwhole-program here.

Stinkfist0 added 3 commits July 2, 2016 17:39

Preliminary MSYS2 + MinGW build scripts and instructions.

d649089

CMakeLists.txt: MinGW tweaks, enforce C++03, suppress warnings for now.

3cc890b

Fix some GCC warnings.

13a8ee0

Fix unused parameter warnings coming from Ifc*.h.

7fdbb1b

Fix warning regarding unreachable code (++jt) on MSVC.

8a6f2b1

iras mentioned this pull request Jul 5, 2016

commented out unreferenced variables names to remove warnings when compiling. #98

Closed

Stinkfist0 added 2 commits July 5, 2016 16:17

Add IfcParse_EXPORT for IfcInvalidTokenException

37e27a5

Fix potentially uninitialized pointer variables.

c5a756c

aothms reviewed Jul 8, 2016
View reviewed changes

Note about OpenCASCADE cyclic dependencies fix.

cfc4a73

Stinkfist0 added 3 commits July 10, 2016 16:56

GCC warning fix: don't generate 'current_enum' variable that is only …

411e222

…set and not used for anything ever

Work around -Wmaybe-uninitialized warnings about boost::optional cons…

26fccfc

…tructs. Also prevent passing of negative values for --bounds.

Remove unused variable.

2040342

CMakeLists.txt: ENABLE_BUILD_OPTIMIZATIONS for GCC (simply enforce -03)

9eb73a6

aothms merged commit 4a85e5e into IfcOpenShell:master Jul 15, 2016

iras mentioned this pull request Jul 19, 2016

leftover WARNING from #99 #105

Closed

Stinkfist0 reviewed Jul 21, 2016
View reviewed changes

Stinkfist0 deleted the msys branch October 17, 2016 14:31

bimintelligence mentioned this pull request Jan 1, 2023

Brep solid from IfcFace #2669

Closed

RickBrice mentioned this pull request Jun 12, 2024

IfcSectionedSolidHorizontal issues #4501

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

MSYS build scripts and instructions#99

MSYS build scripts and instructions#99
aothms merged 12 commits into
IfcOpenShell:masterfrom
Tridify:msys

Stinkfist0 commented Jul 2, 2016

Uh oh!

iras commented Jul 4, 2016

Uh oh!

Stinkfist0 commented Jul 4, 2016

Uh oh!

aothms Jul 8, 2016

Uh oh!

aothms commented Jul 8, 2016

Uh oh!

Stinkfist0 commented Jul 8, 2016 •

edited

Loading

Uh oh!

iras commented Jul 8, 2016 •

edited

Loading

Uh oh!

Stinkfist0 commented Jul 8, 2016 •

edited

Loading

Uh oh!

Stinkfist0 commented Jul 10, 2016 •

edited

Loading

Uh oh!

iras commented Jul 11, 2016

Uh oh!

aothms commented Jul 15, 2016

Uh oh!

Stinkfist0 Jul 21, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Stinkfist0 commented Jul 2, 2016

Uh oh!

iras commented Jul 4, 2016

Uh oh!

Stinkfist0 commented Jul 4, 2016

Uh oh!

aothms Jul 8, 2016

Choose a reason for hiding this comment

Uh oh!

aothms commented Jul 8, 2016

Uh oh!

Stinkfist0 commented Jul 8, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iras commented Jul 8, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Stinkfist0 commented Jul 8, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Stinkfist0 commented Jul 10, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iras commented Jul 11, 2016

Uh oh!

aothms commented Jul 15, 2016

Uh oh!

Stinkfist0 Jul 21, 2016

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Stinkfist0 commented Jul 8, 2016 •

edited

Loading

iras commented Jul 8, 2016 •

edited

Loading

Stinkfist0 commented Jul 8, 2016 •

edited

Loading

Stinkfist0 commented Jul 10, 2016 •

edited

Loading