feat: disable grpc compression#289
Merged
Merged
Conversation
vlastahajek
force-pushed
the
feat/disable-gprc-compression
branch
from
2daa1a4 to
3777e23
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
==========================================
+ Coverage 87.32% 87.47% +0.14%
==========================================
Files 20 20
Lines 1247 1261 +14
Branches 201 204 +3
==========================================
+ Hits 1089 1103 +14
Misses 74 74
Partials 84 84 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vlastahajek
force-pushed
the
feat/disable-gprc-compression
branch
from
3777e23 to
f6bc28d
Compare
karel-rehor
approved these changes
Oct 15, 2025
karel-rehor
left a comment
karel-rehor
left a comment
Contributor
There was a problem hiding this comment.
Looks Good. I like the moving of simpleFlightServer in tests into the utility class. The Javadoc for ClientConfig was missing the new disableGRPCCompression property. I've gone ahead and added this.
fix: properly setting user-agent header
vlastahajek
force-pushed
the
feat/disable-gprc-compression
branch
from
863ab17 to
6555e90
Compare
vlastahajek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Proposed Changes
Added the possibility to disable gRPC compression via the
disableGRPCCompressionparameter in theClientConfig.Fixed also the setting of the
user-agentheader and related tests, where headers are now validated on the server side, because the client interceptor cannot capture transport headers. Theuser-agentheader cannot be set via custom headers, because this header is erased on the transport level, and it is then set differently:https://github.com/grpc/grpc-java/blob/f0a606710bc87da8848225d20710044c34fa4780/netty/src/main/java/io/grpc/netty/Utils.java#L292
Checklist