fix: Moved cryptoOps.py and scenarios.py into the package#1
Merged
Conversation
Contributor
Author
|
I moved the files so that they could be invoked after a pip install of the SDK like so: from keyfactor_v_1_client.wrappers import keyfactor, cryptoOps
cert = keyfactor.pfx_enroll({"Subject":subject,"Template":template,"SANs":SANs,"Metadata":metadata})
csr,key = cryptoOps.createCSR(subject,SANs)
csrcert = keyfactor.csr_enroll({"CSR":csr,"Template":template,"Metadata":metadata})Or a full example here: https://github.com/Keyfactor/command-custom-enrollment-form/blob/main/kfc_enrollment_app/signals.py |
fix(wrapper): `keyfactor.py` will parse username and pass if no token is provided and will use default parameters for `scheme` and `URLbase`.
JDKeyfactor
reviewed
Nov 17, 2022
| description = "A client library for accessing Keyfactor-v1" | ||
|
|
||
| version = "v1.0.0" | ||
| description = "A client library for accessing Keyfactor Command-v1" |
Contributor
There was a problem hiding this comment.
The server component is technically just the "Keyfactor" application, but I don't think this will lead to confusion.
JDKeyfactor
approved these changes
Nov 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.