Fail gracefully when DB and disk don't agree#3838
Open
williamjallen wants to merge 1 commit into
Open
Conversation
Attempting to download a file for which there is a database entry in the `uploadfile` table but nothing on disk currently produces a 500 error. This commit adds error checking to ensure this rare case is handled gracefully.
williamjallen
force-pushed
the
check-uploaded-file-exists-before-download
branch
from
2c9117d to
523a7c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to download a file for which there is a database entry in the
uploadfiletable but nothing on disk currently produces a 500 error. This commit adds error checking to ensure this rare case is handled gracefully.