chore: make principal values public#192
Merged
Merged
Conversation
VisualBean
changed the title
Contributor
|
Make it a public property with a private setter. Also |
VisualBean
approved these changes
Aug 20, 2024
Contributor
Author
|
Thanks for the merge @VisualBean! Any chance of a beta release when you have a minute please? 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
#187 was recently merged, however, the principal value properties were set as private. This was a mistake and should be made public so that they can be used after the asyncapi specs have been processed.
Changelog