chore: make aws condition value explicit#193
Merged
Merged
Conversation
VisualBean
reviewed
Sep 2, 2024
VisualBean
reviewed
Sep 2, 2024
Contributor
|
Note that this is technically a breaking change, but as it is limited to the bindings package, i think we can let it slide. |
Contributor
Author
Okay I see. I can amend the PR to be a |
Contributor
I don't think that is needed in this case. chore or refactor is fine 👍 |
VisualBean
approved these changes
Sep 4, 2024
Contributor
|
Approved. Glad to see us moving closer to the truth, by implementing explicit classes for things, rather than the other way around (y) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
The value of the AWS condition is currently set to AsyncApiAny. This is too open-ended and makes it difficult for the user to parse and use the value when parsing AsyncApi files. This PR sets the structure for
conditionand makes it explicit, which will make using the value on the other side more simple.Changelog
Related Issues
N/A