Skip to content

[E-1] 14-Chains / 03-StructuredOutputChain#375

Merged
teddylee777 merged 3 commits into
LangChain-OpenTutorial:mainfrom
ThePurpleCollar:initial/14-03
Jan 19, 2025
Merged

[E-1] 14-Chains / 03-StructuredOutputChain#375
teddylee777 merged 3 commits into
LangChain-OpenTutorial:mainfrom
ThePurpleCollar:initial/14-03

Conversation

@ThePurpleCollar

@ThePurpleCollar ThePurpleCollar commented Jan 15, 2025

Copy link
Copy Markdown
Contributor

안녕하세요. 리뷰 부탁드리겠습니다.
랭체인노트에서 사용된 퀴즈 예제가 너무 한국적(?)이라서 Topic을 K-FOOD로 수정하였습니다.

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@ThePurpleCollar ThePurpleCollar self-assigned this Jan 15, 2025
jinucho
jinucho reviewed Jan 15, 2025
View reviewed changes

@jinucho jinucho left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Mac
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • [N/A] Image: Image filenames follow guidelines.
  • [ ] Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments:
  1. Overview쪽 코랩과 깃 뱃지의 주소를 변경해야 합니다.(템플릿으로 되어 있습니다.)
  2. from langchain_core.pydantic_v1 import BaseModel
  • import 시 pydantic_v1 경고가 발생 합니다. v2로 변경해야 할 것 같습니다.

@ErikaPark
Included langchain project name & Updated imported package to a newe…
e615a17 
…r version

* 프로젝트명 추가`"LANGCHAIN_PROJECT": "Structured-Output-Chain"`
* `langchain_core.pydantic_v1` ->  `pydantic`
@ErikaPark

ErikaPark commented Jan 15, 2025

Copy link
Copy Markdown
Contributor
  1. Overview쪽 코랩과 깃 뱃지의 주소를 변경해야 합니다.(템플릿으로 되어 있습니다.)

이 부분은 merge된 후 인프라팀에서 워크플로우 돌려서 뱃지 업데이트 하는 것으로 알고 있습니다.

  1. from langchain_core.pydantic_v1 import BaseModel
  • import 시 pydantic_v1 경고가 발생 합니다. v2로 변경해야 할 것 같습니다.

이건 저도 동일한 경고가 발생해 이후 버전으로 반영해 커밋하였습니다.

ErikaPark
ErikaPark reviewed Jan 15, 2025
View reviewed changes

@ErikaPark ErikaPark left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: �Mac

✅ Checklist

  • Template: Tutorials follows the required template.
    • 헤더 아래에 설명 추가 필요
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments:
    • Invoking Generation Chain 섹션에 설명이 추가될 필요가 있어 보입니다. 각 헤더 아래에 간략한 설명을 반드시 추가해야 했던 것으로 기억합니다.
    • References 섹션에 참고자료가 없을 경우 헤더를 삭제해야 할지 고민했으나, 일단 유지하였습니다.
    • 환경변수 설정에서 "LANGCHAIN_PROJECT": "Structured-Output-Chain"을 추가하고 커밋하였습니다.
    • langchain_core.pydantic_v1을 pydantic으로 변경하였으며, 코드가 문제없이 실행되는 것을 확인하고 커밋하였습니다. (참고링크)

@ThePurpleCollar

ThePurpleCollar commented Jan 17, 2025

Copy link
Copy Markdown
Contributor Author

@jinucho @ErikaPark
두 분 피드백 감사드리며, 의견 주신 내용들 다음과 같이 반영하였습니다.

  • 코랩과 깃 뱃지의 주소는 인프라팀에서 일괄 처리한다고 해서 그대로 두었습니다.
  • pydatic 경고는 감사하게도 연서님께서 수정/반영해 주셨습니다.
  • Invoking Generation Chain 아래에 간략히 설명 추가하였습니다.
  • Rerefeces는 우선 유지해 두었습니다. 추후 검수팀의 피드백에 따라 처리하겠습니다.

추가 개선점이 있다면 말씀해 주세요.

jinucho
jinucho approved these changes Jan 17, 2025
View reviewed changes

@jinucho jinucho left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Mac
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • [N/A] Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: 코랩, 깃 뱃지는 제가 디스코드에 잘 못 봤나봐요 ㅎㅎ
    동작 확인 하였고 이상 없습니다.
    고생하셨습니다.

jeong-wooseok
jeong-wooseok approved these changes Jan 18, 2025
View reviewed changes

@jeong-wooseok jeong-wooseok left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Win/Mac/Linux
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {Write freely, 한국어 기술 가능}
  • 코드하였으며 전부 정상 작동합니다. 고생하셨습니다.

ErikaPark
ErikaPark approved these changes Jan 18, 2025
View reviewed changes

@ErikaPark ErikaPark left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Win/Mac/Linux
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.

Comments: 수정사항들 모두 반영하시느라 고생하셨습니다!!

@sohyunwriter sohyunwriter added the docs tutorial label Jan 18, 2025
@teddylee777 teddylee777 merged commit e8febfd into LangChain-OpenTutorial:main Jan 19, 2025
@ThePurpleCollar ThePurpleCollar deleted the initial/14-03 branch January 20, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeong-wooseok jeong-wooseok jeong-wooseok approved these changes

@ErikaPark ErikaPark ErikaPark approved these changes

@jinucho jinucho jinucho approved these changes

Assignees

@ThePurpleCollar ThePurpleCollar

Labels

docs tutorial

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ThePurpleCollar @ErikaPark @jeong-wooseok @jinucho @teddylee777 @sohyunwriter