Skip to content

[E-2] 16-Evaluations / 06-LangSmith-Embedding-Distance-Evaluation#384

Merged
teddylee777 merged 4 commits into
LangChain-OpenTutorial:mainfrom
choincnp:tutorial
Jan 19, 2025
Merged

[E-2] 16-Evaluations / 06-LangSmith-Embedding-Distance-Evaluation#384
teddylee777 merged 4 commits into
LangChain-OpenTutorial:mainfrom
choincnp:tutorial

Conversation

@choincnp

@choincnp choincnp commented Jan 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

kofsitho87
kofsitho87 requested changes Jan 16, 2025
View reviewed changes

@kofsitho87 kofsitho87 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Review Checklist]

  • Review OS:

    • Mac

  • Template Rule 준수 여부:

    • Template Rule 가이드를 준수하였는가? (Check 표기)

  • Table of Contents 링크 확인:

    • Table of Contents의 링크가 원활하게 동작하는지 확인하였는가? (Check 표기)

  • 이미지 파일명 검토:

    • 이미지가 포함되어 있다면, 이미지의 파일명이 가이드를 준수하였는가? (Check 표기)

  • 최신 import 방식 사용 여부:

    • import 구문이 예전 legacy 방식이 아닌 최신 버전을 따르는가? (Check 표기)

  • 코드 동작 확인:

    • 모든 코드가 오류 없이 동작하는가? (Check 표기)
    • Warning 발생 시 코멘트에 적어주세요.

  • 제출 파일 확인:

    • 꼭 필요한 파일들만 제출되었는가?
      • 튜토리얼 외 설정 파일이나 다른 분이 작업한 파일이 포함되었는지 Files Changed에서 확인 부탁드립니다. (Check 표기)

  • 기타 의견:
    pymupdf 패키지를 install 하는 코드를 추가해야 될것 같습니다.
    다른부분은 이상 없었습니다.

Comment thread 16-Evaluations/06-LangSmith-Embedding-Distance-Evaluation.ipynb
" \"langchain_community\",\n",
" \"langchain_openai\",\n",
" \"langchain_huggingface\",\n",
" \"langchain_upstage\",\n",

@kofsitho87 kofsitho87 Jan 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pymupdf 패키지를 install 하는 코드를 추가해야 될것 같습니다.

  • ImportError: PyMuPDF package not found, please install it with pip install pymupdf

@choincnp choincnp Jan 16, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

친절한 리뷰 감사합니다! 추가해서 넣도록 하겠습니다!!

@kofsitho87 kofsitho87 self-requested a review January 16, 2025 09:36
@choincnp choincnp requested review from architectyou and removed request for verydeeeeplearning January 16, 2025 16:41
kofsitho87
kofsitho87 approved these changes Jan 17, 2025
View reviewed changes

@kofsitho87 kofsitho87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Review Checklist]

  • Review OS:

    • Mac

  • Template Rule 준수 여부:

    • Template Rule 가이드를 준수하였는가? (Check 표기)

  • Table of Contents 링크 확인:

    • Table of Contents의 링크가 원활하게 동작하는지 확인하였는가? (Check 표기)

  • [x ] 이미지 파일명 검토:

    • 이미지가 포함되어 있다면, 이미지의 파일명이 가이드를 준수하였는가? (Check 표기)

  • 최신 import 방식 사용 여부:

    • import 구문이 예전 legacy 방식이 아닌 최신 버전을 따르는가? (Check 표기)

  • 코드 동작 확인:

    • 모든 코드가 오류 없이 동작하는가? (Check 표기)
    • Warning 발생 시 코멘트에 적어주세요.

  • 제출 파일 확인:

    • 꼭 필요한 파일들만 제출되었는가?
      • 튜토리얼 외 설정 파일이나 다른 분이 작업한 파일이 포함되었는지 Files Changed에서 확인 부탁드립니다. (Check 표기)

  • 기타 의견:
    특이사항 없습니다. 고생하셨습니다.

architectyou
architectyou approved these changes Jan 18, 2025
View reviewed changes

@architectyou architectyou left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: mac
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: 목차 링크 잘 동작하고 코드 내용도 이상 없이 잘 동작합니다! 로컬 임베딩 모델이 빠져서 저도 아쉽네요 ㅠㅠ 작성해주시느라 고생 많으셨습니다!!! 👍 갓 영 준

@sohyunwriter sohyunwriter added the docs tutorial label Jan 18, 2025
@teddylee777 teddylee777 merged commit 775a6ad into LangChain-OpenTutorial:main Jan 19, 2025
@choincnp choincnp deleted the tutorial branch February 20, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kofsitho87 kofsitho87 kofsitho87 approved these changes

@architectyou architectyou architectyou approved these changes

Assignees

No one assigned

Labels

docs tutorial

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@choincnp @kofsitho87 @architectyou @teddylee777 @sohyunwriter