Skip to content

[E-3] 17-LangGraph/02-Structures/LangGraph-Add-Query-Rewrite#488

Merged
teddylee777 merged 6 commits into
LangChain-OpenTutorial:mainfrom
sunworl:main
Feb 4, 2025
Merged

[E-3] 17-LangGraph/02-Structures/LangGraph-Add-Query-Rewrite#488
teddylee777 merged 6 commits into
LangChain-OpenTutorial:mainfrom
sunworl:main

Conversation

@sunworl

@sunworl sunworl commented Jan 21, 2025

Copy link
Copy Markdown
Contributor

{PR Message - Write freely, remove this bracket if unnecessary}

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@sunworl sunworl self-assigned this Jan 21, 2025
@sunworl sunworl changed the title [E-3] 17-LangGraph/02-Structures-LangGraph-Add-Query-Rewrite [E-3] 17-LangGraph/02-Structures/LangGraph-Add-Query-Rewrite Jan 21, 2025
@chaeyoonyunakim chaeyoonyunakim added docs tutorial proofreading 번역/검수팀 제안사항 반영 labels Jan 21, 2025
samdaseuss
samdaseuss requested changes Jan 23, 2025
View reviewed changes

@samdaseuss samdaseuss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Win/Mac/Linux
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {Write freely, 한국어 기술 가능}

수고하셨습니다 :)

그런데 rag 폴더의 파일은 충돌 때문에 올리지 않는걸로 알고 있는데 혹시 모르니 일단 보류해놓겠습니다!

sunworl and others added 3 commits January 24, 2025 12:56
@sunworl

sunworl commented Jan 24, 2025

Copy link
Copy Markdown
Contributor Author

🖥️ OS: Win/Mac/Linux ✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {Write freely, 한국어 기술 가능}

수고하셨습니다 :)

그런데 rag 폴더의 파일은 충돌 때문에 올리지 않는걸로 알고 있는데 혹시 모르니 일단 보류해놓겠습니다!

rag폴더 삭제하여 충돌 위험 해결했습니다.

@sunworl sunworl requested a review from samdaseuss January 24, 2025 06:07
MoonHeesun
MoonHeesun approved these changes Jan 24, 2025
View reviewed changes

@MoonHeesun MoonHeesun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Win
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments:

고생하셨습니다! 모든 코드가 잘 실행되는 것까지 확인했습니다 :)

MoonHeesun
MoonHeesun previously approved these changes Jan 24, 2025
View reviewed changes

@MoonHeesun MoonHeesun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve 한 상태지만.. 뒤늦게 한 가지 더 comment 남깁니다..!

Comment thread 17-LangGraph/02-Structures/05-LangGraph-Add-Query-Rewrite.ipynb Outdated
"# LangGraph-Add-Query-Rewrite\n",
"\n",
"- Author: [Sunworl Kim](https://github.com/sunworl)\n",
"- Design:\n",

@MoonHeesun MoonHeesun Jan 24, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기여자 프로필 작성 가이드에 따라 design 프로필은 추가해주셔야 할 것 같습니다!

@sunworl sunworl Jan 24, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

놓치고 있었는데, 알려주셔서 감사합니다.
추가했습니다.

@sunworl
[E-3] 17-LangGraph/02-Structures/LangGraph-Add-Query-Rewrite
3a2816c 
기여자 프로필 작성 가이드에 따라 design 프로필 추가
@sunworl sunworl requested a review from MoonHeesun January 24, 2025 14:50
MoonHeesun
MoonHeesun previously approved these changes Jan 24, 2025
View reviewed changes
@sunworl
Update 05-LangGraph-Add-Query-Rewrite.ipynb
34a627a 
"TAVILY_API_KEY" 불필요하여 삭제
chaeyoonyunakim
chaeyoonyunakim approved these changes Feb 1, 2025
View reviewed changes

@chaeyoonyunakim chaeyoonyunakim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 @sunworl 님, peer-review가 진행중입니다만 시간을 줄이기 위해 번역/검수 확인 같이 진행하였습니다. 기술적인 내용이 잘 표현되지 않은 부분들이 있는 듯 하여 몇 가지 문장을 수정 제안 드리니 확인 후 필요하시면 반영 부탁드립니다. 감사합니다.

samdaseuss
samdaseuss approved these changes Feb 2, 2025
View reviewed changes

@samdaseuss samdaseuss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Win/Mac/Linux
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {Write freely, 한국어 기술 가능}
    수고하셨습니다 :)

@sunworl

sunworl commented Feb 3, 2025

Copy link
Copy Markdown
Contributor Author

안녕하세요 @sunworl 님, peer-review가 진행중입니다만 시간을 줄이기 위해 번역/검수 확인 같이 진행하였습니다. 기술적인 내용이 잘 표현되지 않은 부분들이 있는 듯 하여 몇 가지 문장을 수정 제안 드리니 확인 후 필요하시면 반영 부탁드립니다. 감사합니다.

검토해주신 내용 확인하였습니다.
해당 PR이 시간이 좀 지연된 관계로....먼저 merge 후에 번역/검수 부분 수정하여 다시 PR 하는게 좋을 듯 합니다.

@teddylee777 teddylee777 merged commit 7359e42 into LangChain-OpenTutorial:main Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chaeyoonyunakim chaeyoonyunakim chaeyoonyunakim approved these changes

@samdaseuss samdaseuss samdaseuss approved these changes

@MoonHeesun MoonHeesun MoonHeesun approved these changes

Assignees

@sunworl sunworl

Labels

docs tutorial proofreading 번역/검수팀 제안사항 반영

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sunworl @chaeyoonyunakim @samdaseuss @MoonHeesun @teddylee777