[E-2] 17-LangGraph / 01-Core-Features / 11-LangGraph-Branching#515
Merged
Conversation
Contributor
|
🖥️ OS: Win
|
jhboyo
previously approved these changes
Jan 23, 2025
Contributor
There was a problem hiding this comment.
🖥️ OS: Win/Mac/Linux
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- Image: Image filenames follow guidelines.
- Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments: 코드 모두 정상 작동하고 특이사항 없습니다. 고생 많으셨습니다!
suhyun0115
previously approved these changes
Jan 25, 2025
chaeyoonyunakim
dismissed stale reviews from suhyun0115 and jhboyo
via
9e48cc9
chaeyoonyunakim
approved these changes
Jan 25, 2025
chaeyoonyunakim
left a comment
chaeyoonyunakim
left a comment
Contributor
There was a problem hiding this comment.
안녕하세요 @seofield 님, 번역/검수 확인 후 수정 커밋 변경있었습니다.
- 개요 단락에 배치된 그림을 설명 다음에 오도록 변경
- (수평선을 긋는 dash는 References 뒤로만 적용 기준에 따라) line143 '---' 삭제
- block quote >로 들어간 "superstep" 설명을 해당 본문 아래로 재배치
- 그외 몇 가지 사소한 수정 (앞선 3가지 수정이 없었다면 하지 않았을 것 같은) 내용들이 있습니다:
B and C를Node BandNote C로 수정 등
기존 리뷰어 분들 Approval 재요청 드리겠습니다. 감사합니다
jhboyo
approved these changes
Jan 26, 2025
suhyun0115
approved these changes
Jan 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{PR Message - Write freely, remove this bracket if unnecessary}
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.
Review Template (Intial PR)
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N