Skip to content

[N-1] 06-DocumentLoader / 02-PDFLoader#587

Merged
teddylee777 merged 2 commits into
LangChain-OpenTutorial:mainfrom
ppakyeah:06/02-pdf-loader
Feb 7, 2025
Merged

[N-1] 06-DocumentLoader / 02-PDFLoader#587
teddylee777 merged 2 commits into
LangChain-OpenTutorial:mainfrom
ppakyeah:06/02-pdf-loader

Conversation

@ppakyeah

@ppakyeah ppakyeah commented Feb 4, 2025

Copy link
Copy Markdown
Contributor
  • fix formatting (backtick 추가/제거)

{PR Message - Write freely, remove this bracket if unnecessary}

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Proofread: < 06-DocumentLoader / 02-PDFLoader.ipynb> #416 )

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}     

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@ppakyeah ppakyeah self-assigned this Feb 4, 2025
@ppakyeah ppakyeah added the proofreading 번역/검수팀 제안사항 반영 label Feb 4, 2025
@BokyungisaGod

Copy link
Copy Markdown
Contributor

@ppakyeah 님 안녕하세요! 수정사항이 있어 코멘트를 남기게 되었습니다 :)
1.
스크린샷 2025-02-04 오후 8 12 34

References 밑에 ---- 처리를 해야 합니다.

스크린샷 2025-02-04 오후 8 14 47

pypdf -> 소문자를 쓰신 이유가 따로 있을까요?? 따로 이유가 없는거라면 PyPDF로 통일하는 것이 좋아보입니다!

이 두가지를 고친 후, 멘션+코멘트 남겨주시면 approve 하겠습니다!

@ppakyeah

ppakyeah commented Feb 4, 2025

Copy link
Copy Markdown
Contributor Author

@ppakyeah 님 안녕하세요! 수정사항이 있어 코멘트를 남기게 되었습니다 :) 1. 스크린샷 2025-02-04 오후 8 12 34

References 밑에 ---- 처리를 해야 합니다.

스크린샷 2025-02-04 오후 8 14 47 pypdf -> 소문자를 쓰신 이유가 따로 있을까요?? 따로 이유가 없는거라면 PyPDF로 통일하는 것이 좋아보입니다!

이 두가지를 고친 후, 멘션+코멘트 남겨주시면 approve 하겠습니다!

안녕하세요! 수정사항 반영하였습니다 감사합니다!!
@BokyungisaGod

@BokyungisaGod BokyungisaGod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 :)

@teddylee777 teddylee777 merged commit b4b3372 into LangChain-OpenTutorial:main Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

proofreading 번역/검수팀 제안사항 반영

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proofread: < 06-DocumentLoader / 02-PDFLoader.ipynb>

4 participants