Skip to content

Refactor packaging#1052

Merged
edwinyyyu merged 6 commits into
MemMachine:mainfrom
edwinyyyu:refactor_packaging
Mar 3, 2026
Merged

Refactor packaging#1052
edwinyyyu merged 6 commits into
MemMachine:mainfrom
edwinyyyu:refactor_packaging

Conversation

@edwinyyyu

@edwinyyyu edwinyyyu commented Feb 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Purpose of the change

Split memmachine server and client packages. Common models are shared via a common dependency.

Previous packaging system results in corrupted Python environments.

  • Fix development environment
    • no weird symlinks polluting file searches
  • Versioning
    • Client can support additional Python versions that server doesn't.
  • Same standards were applied to Ruff on different Python versions.
  • Uninstalling client no longer breaks server. Uninstalling server no longer breaks client.

Description

Used Claude Code with this plan:
plan.txt
Later amendments are from further smaller prompts.

Fixes/Closes

#1048
#1057

Type of change

[Please delete options that are not relevant.]

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g., code style improvements, linting)
  • Documentation update
  • Project Maintenance (updates to build scripts, CI, etc., that do not affect the main project)
  • Security (improves security without changing functionality)

How Has This Been Tested?

Existing tests, with updated imports.

  • Unit Test
  • Integration Test
  • End-to-end Test
  • Test Script (please provide)
  • Manual verification (list step-by-step instructions)

Checklist

  • I have signed the commit(s) within this pull request
  • My code follows the style guidelines of this project (See STYLE_GUIDE.md)
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • Confirmed all checks passed
  • Contributor has signed the commit(s)
  • Reviewed the code
  • Run, Tested, and Verified the change(s) work as expected

@edwinyyyu edwinyyyu force-pushed the refactor_packaging branch 2 times, most recently from 47918c3 to 2f8c3e5 Compare February 4, 2026 20:02
@sscargal sscargal mentioned this pull request Feb 4, 2026
Closed
@sscargal

sscargal commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

Fixes #1050

@edwinyyyu edwinyyyu force-pushed the refactor_packaging branch 2 times, most recently from 5c1b84e to 8aeaedb Compare February 4, 2026 22:24
@edwinyyyu

edwinyyyu commented Feb 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Roughly ~300 files have no real changes.

@edwinyyyu edwinyyyu force-pushed the refactor_packaging branch 2 times, most recently from a7eda64 to cc6b23a Compare February 4, 2026 22:57
@edwinyyyu edwinyyyu mentioned this pull request Feb 5, 2026
Merged
@edwinyyyu edwinyyyu linked an issue Feb 5, 2026 that may be closed by this pull request
[Bug]: Python installation footguns #1057
Closed
@edwinyyyu edwinyyyu mentioned this pull request Feb 5, 2026
Closed
@edwinyyyu edwinyyyu force-pushed the refactor_packaging branch 7 times, most recently from 7dff120 to bb09af3 Compare February 5, 2026 21:39
@edwinyyyu

edwinyyyu commented Feb 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

All non-skipped unit tests pass at this point, running uv run --all-extras pytest from packages/

@edwinyyyu

edwinyyyu commented Feb 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

All non-skipped integration tests pass at this point, running uv run --all-extras pytest -m integration from repo root.

@edwinyyyu

edwinyyyu commented Feb 5, 2026

Copy link
Copy Markdown
Contributor Author

All non-skipped tests pass from all directories.

@edwinyyyu edwinyyyu added the python:uv Pull requests that update python:uv code label Feb 13, 2026
@edwinyyyu edwinyyyu force-pushed the refactor_packaging branch 5 times, most recently from 08a1673 to 00b4bd5 Compare February 23, 2026 23:40
@edwinyyyu edwinyyyu requested a review from o-love February 23, 2026 23:52
@edwinyyyu

edwinyyyu commented Feb 24, 2026

Copy link
Copy Markdown
Contributor Author

Checkpoint comment here. After this is with unified filtering changes.

@edwinyyyu

edwinyyyu commented Feb 24, 2026

Copy link
Copy Markdown
Contributor Author

Reviewed: All import changes only.

@edwinyyyu

edwinyyyu commented Feb 27, 2026

Copy link
Copy Markdown
Contributor Author

Checkpoint comment here.

@edwinyyyu edwinyyyu force-pushed the refactor_packaging branch 2 times, most recently from 918975c to 9ab089b Compare February 27, 2026 18:43
@edwinyyyu edwinyyyu force-pushed the refactor_packaging branch 3 times, most recently from 24c9be9 to a1d8420 Compare February 27, 2026 21:35
@edwinyyyu edwinyyyu added the documentation Issues related to documentation label Feb 27, 2026
edwinyyyu added 3 commits March 2, 2026 11:03
@edwinyyyu
Checkpoint
baaf97e 
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
@edwinyyyu
Undo unnecessary
c808fbe 
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
@edwinyyyu
Type check on multiple versions
ccc489b 
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
@edwinyyyu edwinyyyu force-pushed the refactor_packaging branch from a1d8420 to f153522 Compare March 2, 2026 19:05
@edwinyyyu
Fix rebase
aff085f 
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
@edwinyyyu edwinyyyu force-pushed the refactor_packaging branch from f153522 to aff085f Compare March 2, 2026 19:09
@SarahScargall

SarahScargall commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

I'm not on the reviewer list, but implementation of the PR will require an update to our /docs/openapi.json file, which was just updated today. I'll work on that update once this is approved.

@edwinyyyu

edwinyyyu commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

I'm not on the reviewer list, but implementation of the PR will require an update to our /docs/openapi.json file, which was just updated today. I'll work on that update once this is approved.

This should only affect the Python package naming. I've replaced all instances I could find in the docs of the original package naming. I think this means that there should be no changes necessary for the OpenAPI JSON.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jealous jealous jealous approved these changes

@o-love o-love o-love approved these changes

@sscargal sscargal Awaiting requested review from sscargal

@jgong jgong Awaiting requested review from jgong

@malatewang malatewang Awaiting requested review from malatewang

@tianAndrew tianAndrew Awaiting requested review from tianAndrew

@SarahScargall SarahScargall Awaiting requested review from SarahScargall

Assignees

No one assigned

Labels

documentation Issues related to documentation priority: high Issue is urgent or highly impactful. Needs to be addressed as soon as possible. python:uv Pull requests that update python:uv code refactor Code refactoring that doesn't add new features.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Python installation footguns

5 participants

@edwinyyyu @sscargal @SarahScargall @jealous @o-love