Skip to content

Remove Mypy#1084

Merged
jealous merged 1 commit into
MemMachine:mainfrom
edwinyyyu:remove_mypy
Feb 13, 2026
Merged

Remove Mypy#1084
jealous merged 1 commit into
MemMachine:mainfrom
edwinyyyu:remove_mypy

Conversation

@edwinyyyu

@edwinyyyu edwinyyyu commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

Purpose of the change

Remove Mypy.

Description

The repository switched to ty at some point but Mypy is still a dev dependency, and there are still references to Mypy.

Type of change

[Please delete options that are not relevant.]

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g., code style improvements, linting)
  • Documentation update
  • Project Maintenance (updates to build scripts, CI, etc., that do not affect the main project)
  • Security (improves security without changing functionality)

How Has This Been Tested?

  • Unit Test
  • Integration Test
  • End-to-end Test
  • Test Script (please provide)
  • Manual verification (list step-by-step instructions)

Checklist

  • I have signed the commit(s) within this pull request
  • My code follows the style guidelines of this project (See STYLE_GUIDE.md)
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • Confirmed all checks passed
  • Contributor has signed the commit(s)
  • Reviewed the code
  • Run, Tested, and Verified the change(s) work as expected

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes Mypy from the project in favor of ty, updating dependency/configuration and documentation references accordingly.

Changes:

  • Dropped mypy from the dev dependency group and removed [tool.mypy] configuration.
  • Updated docs and code comments to refer to a generic “type checker” / ty instead of Mypy.
  • Updated contributor documentation with ty install/run instructions.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
src/memmachine/common/configuration/database_conf.py Reworded comments to remove Mypy-specific references.
pyproject.toml Removed mypy dev dependency and deleted [tool.mypy] section.
STYLE_GUIDE.md Updated type checker documentation from Mypy to ty.
CONTRIBUTING-CORE.md Updated type-checking instructions to use ty instead of Mypy.
Comments suppressed due to low confidence (1)

pyproject.toml:1

  • Docs now state ty is the project type checker and is installed as part of the dev group, but pyproject.toml removes mypy without adding ty to dependency-groups.dev. This can break onboarding and CI/dev workflows that rely on uv sync --group dev to provide the type checker. Consider adding ty to the dev group (optionally pinned) or adjusting the docs to clarify it must be installed separately.
[build-system]

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CONTRIBUTING-CORE.md Outdated
Comment thread CONTRIBUTING-CORE.md Outdated
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sscargal sscargal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@honggyukim honggyukim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jealous jealous merged commit 1d71c4d into MemMachine:main Feb 13, 2026
41 checks passed
SarahScargall pushed a commit to SarahScargall/MemMachine that referenced this pull request Feb 13, 2026
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants