Remove Mypy#1084
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes Mypy from the project in favor of ty, updating dependency/configuration and documentation references accordingly.
Changes:
- Dropped
mypyfrom thedevdependency group and removed[tool.mypy]configuration. - Updated docs and code comments to refer to a generic “type checker” /
tyinstead of Mypy. - Updated contributor documentation with
tyinstall/run instructions.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/memmachine/common/configuration/database_conf.py | Reworded comments to remove Mypy-specific references. |
| pyproject.toml | Removed mypy dev dependency and deleted [tool.mypy] section. |
| STYLE_GUIDE.md | Updated type checker documentation from Mypy to ty. |
| CONTRIBUTING-CORE.md | Updated type-checking instructions to use ty instead of Mypy. |
Comments suppressed due to low confidence (1)
pyproject.toml:1
- Docs now state
tyis the project type checker and is installed as part of thedevgroup, butpyproject.tomlremovesmypywithout addingtytodependency-groups.dev. This can break onboarding and CI/dev workflows that rely onuv sync --group devto provide the type checker. Consider addingtyto thedevgroup (optionally pinned) or adjusting the docs to clarify it must be installed separately.
[build-system]
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
honggyukim
reviewed
Feb 11, 2026
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
26bbdcc to
44f881a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jealous
approved these changes
Feb 13, 2026
SarahScargall
pushed a commit
to SarahScargall/MemMachine
that referenced
this pull request
Feb 13, 2026
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the change
Remove Mypy.
Description
The repository switched to ty at some point but Mypy is still a dev dependency, and there are still references to Mypy.
Type of change
[Please delete options that are not relevant.]
How Has This Been Tested?
Checklist
Maintainer Checklist