Implement QdrantVectorStore by edwinyyyu · Pull Request #1086 · MemMachine/MemMachine

edwinyyyu · 2026-02-09T23:31:30Z

Purpose of the change

Add Qdrant as a vector store backend.

Description

Based on #1379.

Notes:

in-memory Qdrant, REST Qdrant, and gRPC Qdrant all have different behaviors that surface at the Python client level.
approach for NULL values is to not store the key and use IsEmpty instead of IsNull
- IsNull requires explicit Null
- IsEmpty allows IsNull on properties not in the schema
also considered making both missing keys and explicitly None keys result in missing key in database -- this requires using IsEmpty instead of IsNull on Qdrant side -- not chosen because for low cardinality NULL filters, explicit NULL + IsNull approach is faster than missing + IsEmpty -- can be reconsidered before merge if storage is a bigger concern
schema updates not supported
prioritizes CP over AP for registry writes
~~- similarity/distance (e.g. proposed WIP: Normalize similarities to [0, 1] #1095) -- we just use the score_threshold naively for now~~ replaced by Define vector similarity score direction and range #1296

Type of change

[Please delete options that are not relevant.]

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Refactor (does not change functionality, e.g., code style improvements, linting)
Documentation update
Project Maintenance (updates to build scripts, CI, etc., that do not affect the main project)
Security (improves security without changing functionality)

How Has This Been Tested?

Checklist

[Please delete options that are not relevant.]

Maintainer Checklist

Confirmed all checks passed
Contributor has signed the commit(s)
Reviewed the code
Run, Tested, and Verified the change(s) work as expected

malatewang · 2026-04-02T21:58:31Z

+    Not as FilterNot,
+)
+from memmachine_server.common.filter.filter_parser import (
+    Or as FilterOr,


probably we should update the variable name in the filter_parser to just make the name to make more sense

Do you mean the "Or" or something else in "filter_parser"?

I mean we may just rename Or to FilterOr in the filter_parser to make it clearer. Not related to this PR

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds Qdrant as a new vector store backend, including configuration, resource-manager wiring, and a Qdrant-backed VectorStore implementation with tests.

Changes:

Introduces QdrantVectorStore / QdrantVectorStoreCollection with support for upsert/query/get/delete plus filter translation.
Extends database configuration + DatabaseManager / ResourceManager to provision Qdrant clients and expose a VectorStore.
Adds unit + integration tests (including Testcontainers-based Qdrant) and updates dev/test dependencies.

Reviewed changes

Copilot reviewed 13 out of 15 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
pyproject.toml	Extends dev testcontainers extras to include Qdrant.
packages/server/pyproject.toml	Adds optional dependency group for `qdrant-client`.
packages/server/src/memmachine_server/common/vector_store/vector_store.py	Extends collection interface with a `config` property; docstring return type tweak.
packages/server/src/memmachine_server/common/vector_store/qdrant_vector_store.py	New Qdrant vector store implementation (collection ops, filters, registry).
packages/server/src/memmachine_server/common/resource_manager/resource_manager.py	Exposes `get_vector_store()` from `ResourceManager`.
packages/server/src/memmachine_server/common/resource_manager/init.py	Updates `IResourceManager` protocol to include `get_vector_store()`.
packages/server/src/memmachine_server/common/resource_manager/database_manager.py	Adds Qdrant client lifecycle + `get_vector_store()` resolution.
packages/server/src/memmachine_server/common/errors.py	Adds `QdrantConfigurationError`.
packages/server/src/memmachine_server/common/configuration/database_conf.py	Adds `QdrantConf`, provider enum support, parse/serialize integration.
packages/server/server_tests/memmachine_server/conftest.py	Adds Qdrant containers + async clients fixtures (REST, gRPC, distributed).
packages/server/server_tests/memmachine_server/common/vector_store/test_qdrant_vector_store.py	Comprehensive tests for QdrantVectorStore (unit + integration).
packages/server/server_tests/memmachine_server/common/resource_manager/test_database_manager.py	Adds DatabaseManager tests for Qdrant provisioning and validation.
packages/server/server_tests/memmachine_server/common/configuration/test_database_conf.py	Adds Qdrant configuration parsing/defaults tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sscargal · 2026-04-07T22:20:03Z

@edwinyyyu We likely need to update the sample_config files to show how a user would configure the QDrant database, in lieu of the other database options, as you have in the unit tests.

Do we have any checks for misconfigurations, such as when the user configures more than one storage database, that could cause conflicts? ie: If we configure Neo4j and Qdrant and ...

edwinyyyu · 2026-04-07T23:44:52Z

@edwinyyyu We likely need to update the sample_config files to show how a user would configure the QDrant database, in lieu of the other database options, as you have in the unit tests.

Do we have any checks for misconfigurations, such as when the user configures more than one storage database, that could cause conflicts? ie: If we configure Neo4j and Qdrant and ...

It can't be used as a vector_graph_store. The configuration system will reject it because internally it knows the types. There is no way for users to know except by documentation because the configuration file models are not 1-1 with interfaces. #1199 will be one consumer. Before that, specifying a vector store in a configuration file is useless.

edwinyyyu · 2026-04-14T23:38:10Z

Tried on_disk option for vectors but didn't see much effect on performance.

sscargal

LGTM

malatewang · 2026-04-28T17:27:41Z

+    Not as FilterNot,
+)
+from memmachine_server.common.filter.filter_parser import (
+    Or as FilterOr,


I mean we may just rename Or to FilterOr in the filter_parser to make it clearer. Not related to this PR

malatewang · 2026-04-28T17:30:15Z

+            else:
+                qdrant_filter = partition_key_filter
+
+            effective_limit = limit if limit is not None else 10000


The effective_limit violates the interface definition in vector_store.py. Either update the interface docstring or this function.

It's probably not good to allow limit = None. I will make a separate PR to update the API and rebase this.

Some vector store backends will still require a limit smaller than may be requested, but the new comment should work still since it's a limit rather than a quota.

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>

edwinyyyu marked this pull request as draft February 10, 2026 18:26

edwinyyyu force-pushed the qdrant_vector_store branch 5 times, most recently from 4c523d4 to b0b0187 Compare February 11, 2026 21:33

edwinyyyu added the Integration An integration into a 3rd party framework or solution using MemMachine label Feb 13, 2026

edwinyyyu force-pushed the qdrant_vector_store branch 2 times, most recently from 6660b8a to 4a18ef4 Compare February 24, 2026 18:07

edwinyyyu force-pushed the qdrant_vector_store branch 9 times, most recently from a8004ec to e1fa4d6 Compare March 5, 2026 19:55

edwinyyyu marked this pull request as ready for review March 5, 2026 20:07

edwinyyyu requested review from jealous, malatewang and o-love March 5, 2026 20:08

edwinyyyu force-pushed the qdrant_vector_store branch from bfc4c81 to 43e9bda Compare March 5, 2026 21:25

edwinyyyu marked this pull request as draft March 6, 2026 22:30

edwinyyyu force-pushed the qdrant_vector_store branch from 43e9bda to 18e029c Compare March 6, 2026 23:07

edwinyyyu marked this pull request as ready for review March 6, 2026 23:07

edwinyyyu force-pushed the qdrant_vector_store branch 2 times, most recently from 04ddb04 to 110e807 Compare March 9, 2026 19:34

edwinyyyu requested a review from sscargal April 6, 2026 18:43

edwinyyyu force-pushed the qdrant_vector_store branch 2 times, most recently from b08e783 to e06eb12 Compare April 6, 2026 20:30

malatewang reviewed Apr 6, 2026

View reviewed changes

edwinyyyu marked this pull request as draft April 6, 2026 23:43

edwinyyyu force-pushed the qdrant_vector_store branch from e06eb12 to 9747369 Compare April 6, 2026 23:56

edwinyyyu marked this pull request as ready for review April 6, 2026 23:56

sscargal requested a review from Copilot April 7, 2026 22:03

Copilot AI reviewed Apr 7, 2026

View reviewed changes

Copilot started reviewing on behalf of sscargal April 7, 2026 22:18 View session

edwinyyyu modified the milestones: v0.3.5, v0.4.0 Apr 7, 2026

sscargal approved these changes Apr 24, 2026

View reviewed changes

malatewang reviewed Apr 28, 2026

View reviewed changes

edwinyyyu mentioned this pull request Apr 28, 2026

Improve vector store API again #1379

Merged

edwinyyyu added 10 commits April 28, 2026 16:17

Implement QdrantVectorStore

1c9bf07

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>

Wire into server

18914e4

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>

Collection base class renamed

4803810

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>

Return config from collection

3a854a1

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>

Address review

ec40893

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>

Cache client after vector store startup

1125910

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>

IsEmpty is simpler and almost as fast

ea72e53

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>

Fixes

4dbdec3

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>

Early return

6513d41

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>

Address review

574ca1c

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>

malatewang approved these changes May 1, 2026

View reviewed changes

Conversation

edwinyyyu commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of the change

Description

Type of change

How Has This Been Tested?

Checklist

Maintainer Checklist

Uh oh!

malatewang Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

edwinyyyu Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

malatewang Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sscargal commented Apr 7, 2026

Uh oh!

edwinyyyu commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

edwinyyyu commented Apr 14, 2026

Uh oh!

sscargal left a comment

Choose a reason for hiding this comment

Uh oh!

malatewang Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

malatewang Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

edwinyyyu Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

edwinyyyu Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

edwinyyyu commented Feb 9, 2026 •

edited

Loading

edwinyyyu Apr 6, 2026 •

edited

Loading

edwinyyyu commented Apr 7, 2026 •

edited

Loading