Improve metrics#1176
Merged
Merged
Conversation
1704f4b to
2bd54f6
Compare
dcc9c5e to
f41f072
Compare
Contributor
Author
|
Mostly indentation changes -- recommend a different diff viewer |
f41f072 to
07fad31
Compare
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Update with new filtering Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix uv.lock Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Rename space to distance Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Checkpoint update Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Weird vibes Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Checkpoint Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Remove user metrics labels Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Improve metrics collection Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Remove Chroma Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
07fad31 to
6854a36
Compare
jealous
approved these changes
Mar 4, 2026
o-love
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the change
Description
Remove user metrics labels because it is not necessary for any consumers and the application should not need to worry about topology.
Remove hundreds of lines of verbose boilerplate.
Makes implementation of future integrations easier.
Explored alternative of trying to use a decorator but then it's not clean to pass the correct metrics factory to the decorator.
Type of change
Breaks using user_metrics_labels. Also, metrics labels/names have changed.
How Has This Been Tested?
Manually tested telling Claude Code to use a script to get metrics.
demo_metrics.py
Checklist
Maintainer Checklist