chore(ci): move Node 20 GitHub Actions jobs to Node 24#1230
Closed
DeoJin wants to merge 1 commit into
Closed
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions workflows to run on newer Node.js versions (22/24), aligning CI with the upcoming GitHub Actions Node 20 deprecation and keeping TypeScript client and docs validation jobs compatible.
Changes:
- Move TypeScript client test and publish workflows from Node 20.19.x to Node 24.x.
- Update docs validation workflow matrix from Node 20/22 to Node 22/24.
- Upgrade docs workflow actions to
actions/checkout@v4andactions/setup-node@v4.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/ts-client-test.yml | Switch ts-client CI test job to Node 24.x. |
| .github/workflows/ts-client-publish.yml | Switch ts-client publish job to Node 24.x. |
| .github/workflows/docs-checks.yml | Update docs validation matrix to 22/24 and bump checkout/setup-node actions to v4. |
Comments suppressed due to low confidence (1)
.github/workflows/docs-checks.yml:86
- There are multiple trailing blank lines at the end of this workflow file (after the last step). Consider removing the extra empty lines to keep the YAML clean and reduce noisy diffs in future edits.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jealous
approved these changes
Mar 17, 2026
Contributor
|
@DeoJin please sign your commit. I cannot merge it because the commit is not signed. |
sscargal
requested changes
Mar 18, 2026
sscargal
left a comment
sscargal
left a comment
Contributor
There was a problem hiding this comment.
Please implement the suggestions. Thanks.
| # Step 1: Checkout the repository code | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v3 | ||
| uses: actions/checkout@v4 |
Contributor
There was a problem hiding this comment.
We should move to v5 at a minimum, which now uses node 24. See https://github.com/actions/checkout. v6 is available.
| # Step 2: Set up Node.js for the current matrix version | ||
| - name: Set up Node.js | ||
| uses: actions/setup-node@v3 | ||
| uses: actions/setup-node@v4 |
Contributor
There was a problem hiding this comment.
We should move to v5 at a minimum, which uses node 24 as the default. See https://github.com/actions/setup-node for details. v6 is the latest.
sscargal
added a commit
to sscargal/MemMachine
that referenced
this pull request
Apr 14, 2026
GitHub Actions is deprecating Node 20 runners on 2026-06-02. Three workflow files still pinned Node 20 and used checkout@v3 / setup-node@v3. Adopt the core of PR MemMachine#1230 (by @DeoJin): update the matrix and version pins so CI runs on Node 22 and 24. Go further than MemMachine#1230 on the action versions — jump actions/checkout and actions/setup-node to @v6 (latest) rather than @v4, since @v4 itself runs on Node 20 and would re-trip the same deprecation. @v5 is the floor (defaults to Node 24); @v6 is current. Audited five additional workflows that carry actions/setup-python@v5 and actions/upload-artifact@v4; those action versions already bundle Node 24 binaries and require no changes. Refs: MemMachine#1221 Closes: MemMachine#1230 Co-authored-by: DeoJin <deojin@users.noreply.github.com> Signed-off-by: Steve Scargall <37674041+sscargal@users.noreply.github.com>
13 tasks
sscargal
added a commit
to sscargal/MemMachine
that referenced
this pull request
Apr 14, 2026
GitHub Actions is deprecating Node 20 runners on 2026-06-02. This is a repo-wide sweep to eliminate all Node-20-based JS action pins before the cutover. Scope: - Bump node-version pins and matrix values off Node 20: - docs-checks.yml matrix [20, 22] → [22, 24] - ts-client-test.yml 20.19.x → 24.x - ts-client-publish.yml 20.19.x → 24.x - Bump every actions/checkout and actions/setup-node reference that was still at @V3 or @v4 up to @v6 (latest). @v4 runs on Node 20 and would re-trip the same deprecation warning; @v5 is the minimum safe pin (defaults to Node 24) and @v6 is the current release. Workflows touched: build-python, check-uvlockfile, docker-image, docs-checks, generate-openapi, installation-test, openclaw_plugin_publish, sbom, sync-platform-openapi, test-python-client-package, test-server-package, ts-client-publish, ts-client-test. - Workflows already on @v5 (lint, pytest, pytest-integration) are left as-is; @v5 defaults to Node 24 and is not deprecation-affected. - actions/setup-python@v5 and actions/upload-artifact@v4 were audited and need no change; those action versions already bundle Node 24 binaries. Adopts and completes the intent of PR MemMachine#1230 (by @DeoJin) which covered only the first three files. Closing that PR in favor of this repo-wide sweep; credit preserved via co-authorship. Refs: MemMachine#1221 Closes: MemMachine#1230 Co-authored-by: DeoJin <deojin@users.noreply.github.com> Signed-off-by: Steve Scargall <37674041+sscargal@users.noreply.github.com>
pull Bot
pushed a commit
to longduoduo112/MemMachine
that referenced
this pull request
Apr 17, 2026
chore: bump Node 20 → 24 across GitHub Actions workflows GitHub Actions is deprecating Node 20 runners on 2026-06-02. This is a repo-wide sweep to eliminate all Node-20-based JS action pins before the cutover. Scope: - Bump node-version pins and matrix values off Node 20: - docs-checks.yml matrix [20, 22] → [22, 24] - ts-client-test.yml 20.19.x → 24.x - ts-client-publish.yml 20.19.x → 24.x - Bump every actions/checkout and actions/setup-node reference that was still at @V3 or @v4 up to @v6 (latest). @v4 runs on Node 20 and would re-trip the same deprecation warning; @v5 is the minimum safe pin (defaults to Node 24) and @v6 is the current release. Workflows touched: build-python, check-uvlockfile, docker-image, docs-checks, generate-openapi, installation-test, openclaw_plugin_publish, sbom, sync-platform-openapi, test-python-client-package, test-server-package, ts-client-publish, ts-client-test. - Workflows already on @v5 (lint, pytest, pytest-integration) are left as-is; @v5 defaults to Node 24 and is not deprecation-affected. - actions/setup-python@v5 and actions/upload-artifact@v4 were audited and need no change; those action versions already bundle Node 24 binaries. Adopts and completes the intent of PR MemMachine#1230 (by @DeoJin) which covered only the first three files. Closing that PR in favor of this repo-wide sweep; credit preserved via co-authorship. Refs: MemMachine#1221 Closes: MemMachine#1230 Signed-off-by: Steve Scargall <37674041+sscargal@users.noreply.github.com> Co-authored-by: DeoJin <deojin@users.noreply.github.com>
edwinyyyu
pushed a commit
to edwinyyyu/MemMachine
that referenced
this pull request
Apr 20, 2026
chore: bump Node 20 → 24 across GitHub Actions workflows GitHub Actions is deprecating Node 20 runners on 2026-06-02. This is a repo-wide sweep to eliminate all Node-20-based JS action pins before the cutover. Scope: - Bump node-version pins and matrix values off Node 20: - docs-checks.yml matrix [20, 22] → [22, 24] - ts-client-test.yml 20.19.x → 24.x - ts-client-publish.yml 20.19.x → 24.x - Bump every actions/checkout and actions/setup-node reference that was still at @V3 or @v4 up to @v6 (latest). @v4 runs on Node 20 and would re-trip the same deprecation warning; @v5 is the minimum safe pin (defaults to Node 24) and @v6 is the current release. Workflows touched: build-python, check-uvlockfile, docker-image, docs-checks, generate-openapi, installation-test, openclaw_plugin_publish, sbom, sync-platform-openapi, test-python-client-package, test-server-package, ts-client-publish, ts-client-test. - Workflows already on @v5 (lint, pytest, pytest-integration) are left as-is; @v5 defaults to Node 24 and is not deprecation-affected. - actions/setup-python@v5 and actions/upload-artifact@v4 were audited and need no change; those action versions already bundle Node 24 binaries. Adopts and completes the intent of PR MemMachine#1230 (by @DeoJin) which covered only the first three files. Closing that PR in favor of this repo-wide sweep; credit preserved via co-authorship. Refs: MemMachine#1221 Closes: MemMachine#1230 Signed-off-by: Steve Scargall <37674041+sscargal@users.noreply.github.com> Co-authored-by: DeoJin <deojin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1221
Validation
pm install (in packages/ts-client)
pm run build (in packages/ts-client)
ode -e "require('./dist/index.js'); console.log('ts-client dist import smoke test: ok')" (in packages/ts-client)
Note:
pm test -- --runInBand in packages/ts-client currently fails on the repo's existing Jest/ts-jest preset mismatch (Preset ts-jest not found), independent of this workflow-only change.