Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds NuGet package signing and authenticity verification to the standard
ModularityKit.Mutatorrelease path and wires the attested publish flow intoRelease Drafter.Highlights
Signed release artifacts
.nupkgin the shared publish workflow withdotnet nuget sign.Verification in release and publish flows
dotnet nuget verify --all --certificate-fingerprint ...immediately after packing.Release workflow integration
publish-attested.ymlcallable viaworkflow_call.release-drafter.ymlto invoke the attested publish workflow instead of duplicating draft release asset upload steps.Documentation and local validation
Docs/Package-Signing.mdwith the signing approach, required secrets, and local verification guidance.README.md,Docs/Home.md, andtoc.yml.task verify:package-signingfor local signature verification.Why
Issue #50 asks for signed NuGet packages, authenticity checks, CI validation, and discoverable documentation without changing the package surface area. The repository already had a shared pack/publish path, so the right move was to harden that path directly instead of introducing a second release flow.
This keeps release behavior explicit and auditable while preserving normal local development without exposing signing material.
Checks
dotnet build ModularityKit.Mutator.slnx -c Releasedocfx docfx.jsonBuilds successfully in this environment with existing DocFX link warnings unrelated to this change.
task --dry verify:package-signing PACKAGE=dist/example.nupkg FINGERPRINT=ABC123Closes