Conversation
Introduce NUGET_SIGN_SKIP_VERIFICATION to allow skipping signed package verification. Expose a new signature_verification_enabled output (steps.signing.outputs.verify_enabled) and write verify_enabled to GITHUB_OUTPUT based on the env/secret. Update publish-artifacts, publish-packages, publish-attested and release-drafter to accept the new input/secret and gate 'Verify signed packages' steps on both signing_enabled and signature_verification_enabled. This enables disabling verification in CI without turning off signing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR expands benchmark coverage for
ModularityKit.Mutatorby adding dedicated diagnostics and concurrency benchmark suites, then updates the CI signing workflow with optional signed package verification.Highlights
Diagnostics benchmarks
Benchmarks/Diagnostics.Concurrency benchmarks
Benchmarks/Concurrency.Package signing workflow
NUGET_SIGN_SKIP_VERIFICATIONsupport.signature_verification_enabledfrom signing workflow steps.Why
Issue #58 asks for benchmark visibility into diagnostics overhead across audit, history, and interception paths.
The new concurrency suite adds runtime-level performance coverage for parallel execution, gate contention, and batch scheduling scenarios.
The signing workflow update makes package publishing more flexible by separating signing from signature verification.
Checks
dotnet build Benchmarks/ModularityKit.Mutator.Benchmarks.csproj -c ReleaseCloses