Skip to content

Merging new scopes and manifest features#239

Merged
Sourceless merged 23 commits into
edgefrom
master
Feb 11, 2021
Merged

Merging new scopes and manifest features#239
Sourceless merged 23 commits into
edgefrom
master

Conversation

@Valentinolucas

@Valentinolucas Valentinolucas commented Feb 10, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Add scopes by default
  • Manifest spec guid

strutt and others added 21 commits January 29, 2021 14:42
@strutt
APM-1707 Add spec guids to manifest file processing
f5c4178
@strutt
APM-1707 Validate against registered api meta data
74ca817
@strutt
APM-1707 Add canary-api id/spec_ids
bb6676e
@strutt
APM-1707 Tweak schema, bugfix update-schema, and upgrade tests
9d81ecf
@strutt
APM-1707 Add canary api manifest test case for v1.1.0
6cae835
@strutt
APM-1556 Include api_guid in product attributes
c71f8e6 
Mark meta.api.id as deprecated. Prefer meta.api.guid.
@HenryIwanejko
APM-1701 Add default scopes to products
6c68f6d
@HenryIwanejko
APM-1701 Add raw service name to deploy product
16e6de0
@HenryIwanejko
APM-1701 Update proxy deployment to use correct var
84814e2
@HenryIwanejko
APM-1701 Update var rename
7399775
@strutt
DRY with the required attribute names
a773ed5
@strutt
Revert requirements for guids on products
925f477
@strutt
APM-1707 Add role to add AssignMessage.SetApiGuids to proxy
3506c12
@strutt
APM-1707 invoke role in pipeline
0f4d80d
@strutt
Merge pull request #232 from NHSDigital/APM-1707-api-spec-guids-in-ma…
5068303 
…nifest

APM-1707 Add spec guids to manifest file processing
@Valentinolucas
Merge branch 'master' into APM-1701-Set-default-scopes
5b85582
@Valentinolucas
APM-1701 Change default scopes names
ee764a6
@strutt
APM-1162 Allow deprecated of meta w/ api.id instead of api.guid
d8a3451
@acarriedev
Merge pull request #238 from NHSDigital/APM-1162-bugfix-add-apim-guid…
231d6b1 
…s-policy

APM-1162 Allow deprecated of meta w/ api.id instead of api.guid
@Valentinolucas
Merge branch 'master' into APM-1701-Set-default-scopes
a0d7910
@Valentinolucas
Merge pull request #235 from NHSDigital/APM-1701-Set-default-scopes
d97d48a 
APM-1701 Add default scopes to products
strutt
strutt reviewed Feb 11, 2021
View reviewed changes
Comment thread ansible/Makefile Outdated
Comment thread ansible/roles/deploy-apigee-product-and-spec/tasks/main.yml
Valentinolucas and others added 2 commits February 11, 2021 13:49
@Valentinolucas
APM-1701 Added guard-SERVICE_NAME to check for variable in ansible/ma…
e5cf959 
…kefile deploy-apigee-product-and-spec
@Valentinolucas
Merge pull request #240 from NHSDigital/APM-1701-Set-default-scopes
078cde1 
APM-1701 Added guard-SERVICE_NAME to check for variable in ansible/ma…
@Valentinolucas Valentinolucas marked this pull request as ready for review February 11, 2021 14:28
Sourceless
Sourceless approved these changes Feb 11, 2021
View reviewed changes

@Sourceless Sourceless left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@Sourceless Sourceless merged commit 93255ec into edge Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@strutt strutt strutt approved these changes
@Sourceless Sourceless Sourceless approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Valentinolucas @Sourceless @strutt @HenryIwanejko @acarriedev