latest master pull#255
Merged
Merged
Conversation
Added the new fixedpath variable to the target path (as disablesuffixcopy stops the automatic amendment of the proxy.pathsuffix)
Added a new HOSTED_TARGET_CONNECTION_WITH_PATH_REWRITE to avoid causing issues with others using HOSTED_TARGET_CONNECTION.
Remove unnecessary ansible lookup as it's actually an apigee variable.
Tidying up file
Fixedpath variable potentially being read as an Ansible variable when in fact it is an apigee run time variable, changing to single curly braces to align with how it is written in Apigee
Altered method of changing target connection per Ben Strutt advice.
Inline with other ansible variables
Possibly causing failures in NHS App tests due to new variable, adding if (as seen in pr_number) to determine if to add or not.
Conditional removed
Added HOSTED_TARGET_CONNECTION_WITH_PATH_REWRITE
apm-1865: terraform upgrade
…-user-access-key mm: remove unused roles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add any other relevant notes or explanations here. Remove this line if you have nothing to add.