Skip to content

Revert "AMB-783 Refactor monitoring by default feature" #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acarriedev merged 1 commit into from
Jul 26, 2021
Merged

Revert "AMB-783 Refactor monitoring by default feature" #342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
150 changes: 83 additions & 67 deletions azure/templates/deploy-service.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,95 +255,111 @@ steps:
- bash: |
set -euo pipefail

export MONITORING_STAGE_NAME="${{ replace(parameters.stage_name, '_', '-') }}"
echo "MONITORING_STAGE_NAME=${MONITORING_STAGE_NAME}"

if [[ "${{ parameters.apigee_environment }}" == "prod" ]]; then
export url="https://api.service.nhs.uk/monitoring-sd/service"
export status_body='{ "${{ parameters.service_name }}": { "${{ parameters.apigee_environment }}": [ "${{ parameters.service_name }}@$(MONITORING_STAGE_NAME)=http_2xx_with_api_key https://api.service.nhs.uk/${{ parameters.service_base_path }}/_status" ] } }'
export ping_body='{ "${{ parameters.service_name }}": { "${{ parameters.apigee_environment }}": [ "${{ parameters.service_name }}@$(MONITORING_STAGE_NAME)=http_2xx https://api.service.nhs.uk/${{ parameters.service_base_path }}/_ping" ] } }'
export status_endpoint_response=`curl -s -o /dev/null -w '%{http_code}' -H "apikey: $(status-endpoint-api-key)" https://api.service.nhs.uk/${{ parameters.service_base_path }}/_status`
export ping_endpoint_response=`curl -s -o /dev/null -w '%{http_code}' -H "apikey: $(status-endpoint-api-key)" https://api.service.nhs.uk/${{ parameters.service_base_path }}/_ping`
else
export url="https://internal-dev.api.service.nhs.uk/monitoring-sd/service"
export status_body='{ "${{ parameters.service_name }}": { "${{ parameters.apigee_environment }}": [ "${{ parameters.service_name }}@$(MONITORING_STAGE_NAME)=http_2xx_with_api_key https://${{ parameters.apigee_environment }}.api.service.nhs.uk/${{ parameters.service_base_path }}/_status" ] } }'
export ping_body='{ "${{ parameters.service_name }}": { "${{ parameters.apigee_environment }}": [ "${{ parameters.service_name }}@$(MONITORING_STAGE_NAME)=http_2xx https://${{ parameters.apigee_environment }}.api.service.nhs.uk/${{ parameters.service_base_path }}/_ping" ] } }'
export status_endpoint_response=`curl -s -o /dev/null -w '%{http_code}' -H "apikey: $(status-endpoint-api-key)" https://${{ parameters.apigee_environment }}.api.service.nhs.uk/${{ parameters.service_base_path }}/_status`
export ping_endpoint_response=`curl -s -o /dev/null -w '%{http_code}' -H "apikey: $(status-endpoint-api-key)" https://${{ parameters.apigee_environment }}.api.service.nhs.uk/${{ parameters.service_base_path }}/_ping`
fi

echo "##vso[task.setvariable variable=url]$url"
echo "##vso[task.setvariable variable=status_body]$status_body"
echo "##vso[task.setvariable variable=ping_body]$ping_body"
displayName: 'Set monitoring variables'
echo service_base_path = ${{ parameters.service_base_path }}
echo _status_response=$status_endpoint_response
echo _ping_response=$ping_endpoint_response
echo "##vso[task.setvariable variable=status_endpoint_response]$status_endpoint_response"
echo "##vso[task.setvariable variable=ping_endpoint_response]$ping_endpoint_response"
displayName: 'Check _ping and _status endpoints'

- bash: |
set -euo pipefail

- ${{ if eq(parameters.enable_monitoring, true) }}:
- bash: |
set -euo pipefail
echo "Setting stage name as snake case for monitoring"
export MONITORING_STAGE_NAME="${{ replace(parameters.stage_name, '_', '-') }}"
echo "MONITORING_STAGE_NAME=${MONITORING_STAGE_NAME}"
echo "##vso[task.setvariable variable=MONITORING_STAGE_NAME]$MONITORING_STAGE_NAME"

if [[ "${{ parameters.service_base_path }}" == *"-pr-"* ]]; then
export is_pull_request=true
else
export is_pull_request=false
fi

if [[ "${{ parameters.apigee_environment }}" == "prod" ]]; then
export ping_endpoint_response=`curl -s -o /dev/null -w '%{http_code}' -H "apikey: $(status-endpoint-api-key)" https://api.service.nhs.uk/${{ parameters.service_base_path }}/_ping`
if [[ $(status_endpoint_response) == "200" ]]; then
if [[ $is_pull_request == 'true' ]]; then
echo "_status endpoint is present in the proxy, however we dont monitor pull requests"
echo "##vso[task.setvariable variable=set_status_monitoring]false"
else
export ping_endpoint_response=`curl -s -o /dev/null -w '%{http_code}' -H "apikey: $(status-endpoint-api-key)" https://${{ parameters.apigee_environment }}.api.service.nhs.uk/${{ parameters.service_base_path }}/_ping`
if [[ "${{ parameters.enable_status_monitoring }}" == "False" ]]; then
echo "_status endpoint monitoring is disabled"
echo "##vso[task.setvariable variable=set_status_monitoring]false"
else
echo "_status endpoint is present in the proxy, we will enable monitoring by default"
echo "##vso[task.setvariable variable=set_status_monitoring]true"
fi
fi

echo _ping_response=$ping_endpoint_response
echo "##vso[task.setvariable variable=ping_endpoint_response]$ping_endpoint_response"
displayName: 'Check _ping'

- bash: |
set -euo pipefail

if [[ "${{ parameters.service_base_path }}" == *"-pr-"* ]]; then
echo "##vso[task.setvariable variable=set_ping_monitoring]false"
else
if [[ $is_pull_request == 'true' ]]; then
echo "WARNING: Please add a _status endpoit to your proxy before releasing or your release will fail. Or use the flag 'enable_status_monitoring=false' if your API don't support _status healthcheck"
echo "##vso[task.setvariable variable=set_status_monitoring]false"
else
if [[ $(ping_endpoint_response) == "200" ]]; then
echo "##vso[task.setvariable variable=set_ping_monitoring]true"
if [[ "${{ parameters.enable_status_monitoring }}" == "False" ]]; then
echo "_status endpoint monitoring is disabled"
echo "##vso[task.setvariable variable=set_status_monitoring]false"
else
echo "##vso[task.logissue type=error]Your proxy dont have a _ping endpoint therefore we can't monitor this proxy and it should not be released, use the flag 'enable_monitoring=false' if your API doesn't support _ping healthcheck."
echo "ERROR: Your proxy dont have a _status endpoint therefore we can't monitor this proxy and it should not be released"
exit 1
fi
fi
displayName: 'Set ping endpoint monitoring'

- ${{ if eq(parameters.enable_monitoring, false) }}:
- bash :
echo "_ping endpoint monitoring is disabled"
echo "##vso[task.setvariable variable=set_ping_monitoring]false"
displayName: 'Set ping endpoint monitoring'

- ${{ if eq(parameters.enable_status_monitoring, true) }}:
- bash: |
set -euo pipefail
fi
fi
fi

if [[ "${{ parameters.apigee_environment }}" == "prod" ]]; then
export status_endpoint_response=`curl -s -o /dev/null -w '%{http_code}' -H "apikey: $(status-endpoint-api-key)" https://api.service.nhs.uk/${{ parameters.service_base_path }}/_status`
if [[ $(ping_endpoint_response) == "200" ]]; then
if [[ $is_pull_request == 'true' ]]; then
echo "_ping endpoint is present in the proxy, however we dont monitor pull requests"
echo "##vso[task.setvariable variable=set_ping_monitoring]false"
else
export status_endpoint_response=`curl -s -o /dev/null -w '%{http_code}' -H "apikey: $(status-endpoint-api-key)" https://${{ parameters.apigee_environment }}.api.service.nhs.uk/${{ parameters.service_base_path }}/_status`
if [[ "${{ parameters.enable_monitoring }}" == "False" ]]; then
echo "_ping endpoint monitoring is disabled"
echo "##vso[task.setvariable variable=set_ping_monitoring]false"
else
echo "_ping endpoint is present in the proxy, we will enable monitoring by default"
echo "##vso[task.setvariable variable=set_ping_monitoring]true"
fi
fi

echo _status_response=$status_endpoint_response
echo "##vso[task.setvariable variable=status_endpoint_response]$status_endpoint_response"
displayName: 'Check _status'

- bash: |
set -euo pipefail

if [[ "${{ parameters.service_base_path }}" == *"-pr-"* ]]; then
echo "##vso[task.setvariable variable=set_status_monitoring]false"
else
if [[ $is_pull_request == 'true' ]]; then
echo "WARNING: Please add a _ping endpoit to your proxy before releasing or your release will fail."
echo "##vso[task.setvariable variable=set_ping_monitoring]false"
else
if [[ $(status_endpoint_response) == "200" ]]; then
echo "##vso[task.setvariable variable=set_status_monitoring]true"
if [[ "${{ parameters.enable_monitoring }}" == "False" ]]; then
echo "_ping endpoint monitoring is disabled"
echo "##vso[task.setvariable variable=set_ping_monitoring]false"
else
echo "##vso[task.logissue type=error]Your proxy dont have a _status endpoint therefore we can't monitor this proxy and it should not be released, use the flag 'enable_status_monitoring=false' if your API don't support _status healthcheck."
"ERROR: Your proxy dont have a _ping endpoint therefore we can't monitor this proxy and it should not be released"
exit 1
fi
fi
displayName: 'Set status endpoint monitoring'
fi

displayName: 'Check monitoring'

- bash: |
set -euo pipefail

- ${{ if eq(parameters.enable_status_monitoring, false) }}:
- bash :
echo "_status endpoint monitoring is disabled"
echo "##vso[task.setvariable variable=set_status_monitoring]false"
displayName: 'Set status endpoint monitoring'
if [[ "${{ parameters.apigee_environment }}" == "prod" ]]; then
export url="https://api.service.nhs.uk/monitoring-sd/service"
export status_body='{ "${{ parameters.service_name }}": { "${{ parameters.apigee_environment }}": [ "${{ parameters.service_name }}@$(MONITORING_STAGE_NAME)=http_2xx_with_api_key https://api.service.nhs.uk/${{ parameters.service_base_path }}/_status" ] } }'
export ping_body='{ "${{ parameters.service_name }}": { "${{ parameters.apigee_environment }}": [ "${{ parameters.service_name }}@$(MONITORING_STAGE_NAME)=http_2xx https://api.service.nhs.uk/${{ parameters.service_base_path }}/_ping" ] } }'
else
export url="https://internal-dev.api.service.nhs.uk/monitoring-sd/service"
export status_body='{ "${{ parameters.service_name }}": { "${{ parameters.apigee_environment }}": [ "${{ parameters.service_name }}@$(MONITORING_STAGE_NAME)=http_2xx_with_api_key https://${{ parameters.apigee_environment }}.api.service.nhs.uk/${{ parameters.service_base_path }}/_status" ] } }'
export ping_body='{ "${{ parameters.service_name }}": { "${{ parameters.apigee_environment }}": [ "${{ parameters.service_name }}@$(MONITORING_STAGE_NAME)=http_2xx https://${{ parameters.apigee_environment }}.api.service.nhs.uk/${{ parameters.service_base_path }}/_ping" ] } }'
fi

echo "##vso[task.setvariable variable=url]$url"
echo "##vso[task.setvariable variable=status_body]$status_body"
echo "##vso[task.setvariable variable=ping_body]$ping_body"
displayName: Set monitoring url and body

- bash: |
curl --fail -X 'POST' -H 'apikey: $(MONITORING_API_KEY)' -d '$(status_body)' $(url)
displayName: Enable _status monitoring
Expand Down