Skip to content

AMB-783 Readded changing enabling monitoring to false when _ping or _… #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewaclark21 merged 6 commits into from
Aug 5, 2021
Merged

AMB-783 Readded changing enabling monitoring to false when _ping or _… #353

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
165e044
AMB-783 Readded changing enabling monitoring to false when _ping or _…
matthewaclark21 Aug 4, 2021
8fcf980
Merge branch 'master' into AMB-783-fix-monitoring-default-503-status-…
RyanThomas1214 Aug 4, 2021
5cb83cc
AMB-783 removed pull-request condition from deleting endpoints
matthewaclark21 Aug 4, 2021
a82503c
Merge branch 'AMB-783-fix-monitoring-default-503-status-response' of …
matthewaclark21 Aug 4, 2021
d4d956c
AMB-783 Readded is_pull_request
matthewaclark21 Aug 4, 2021
992a61c
Merge branch 'AMB-783-fix-monitoring-default-503-status-response' of …
matthewaclark21 Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions azure/templates/deploy-service.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,7 @@ steps:

if [[ $ping_endpoint_response != "200" ]]; then
echo "##vso[task.logissue type=error]Your proxy doesn't have a _ping endpoint therefore we can't monitor this proxy and it should not be released, use the flag 'enable_monitoring=false' if your API doesn't support _ping healthcheck."
echo "##vso[task.setvariable variable=enable_ping_monitoring]false"
exit 1
fi
displayName: 'Check _ping'
Expand All @@ -319,6 +320,7 @@ steps:

if [[ $status_endpoint_response != "200" ]]; then
echo "##vso[task.logissue type=error]Your proxy doesn't have a _status endpoint therefore we can't monitor this proxy and it should not be released, use the flag 'enable_status_monitoring=false' if your API doesn't support _status healthcheck."
echo "##vso[task.setvariable variable=enable_status_monitoring]false"
exit 1
fi

Expand Down