host_target_healthcheck_suffix defaults#440
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
This change should be under hosted_target_healthcheck_suffix not hosted_target_connection_path_suffix
to being defined within the pipeline definitions rather than in ansible.
PhilipSkinner
force-pushed
the
healthcheck-defaults
branch
from
93b035d to
0145217
Compare
acarriedev
approved these changes
Jun 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the default value for the
host_target_healthcheck_suffixvalue to being defined within the pipeline definitions rather than in ansible.This attempts to correct a bug introduced with #438.
The previous PR allowed this value to be configurable - where as before it was always resolving to the defaulted
/_statuswithin the ansible variableHOSTED_TARGET_HEALTHCHECK- it was defaulting to the value of an empty string. If you configured thehost_target_healthcheck_suffixvariable within your pipelines to/_statusthen this would not cause you issues.