CCM-1179#445
Merged
Merged
Conversation
PhilipSkinner
force-pushed
the
CCM-1179-release-process
branch
3 times, most recently
from
d38b4ef to
b7bbeb0
Compare
Author
|
Testing this with different values gives:
|
PhilipSkinner
force-pushed
the
CCM-1179-release-process
branch
from
b7bbeb0 to
6757a5b
Compare
PhilipSkinner
force-pushed
the
CCM-1179-release-process
branch
from
6757a5b to
3ea647e
Compare
almas-liaqat
approved these changes
Jul 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There is a regular expression which evaluates the value in
SERVICE_ARTIFACT_NAMEto determine the version of the deployed version.Unfortunately this doesn't work for tagged versions where there is no suffix value (-alpha etc).
This PR updates the regex to allow for versions with a suffix and without.
When we deployed prior to this change our
/_pingendpoint would return an empty version identifier:Post deployment with this fix, this value is populated correctly: