Feature/36735/oxford slowness#104
Merged
Merged
Conversation
| varpath = VAR_PATH_CLASS_MAP[varpathclass] | ||
| end | ||
| genocolorectal.add_variant_class(varpath) | ||
| genocolorectal.add_variant_class(varpath) if varpath.present? |
Contributor
There was a problem hiding this comment.
Was this supposed to be part of this ticket?
Contributor
Author
There was a problem hiding this comment.
No @lauramccluskey1 , but I noticed a lot of time in logs this string being logged " Bad variant class string given: ; cannot proces" unnecessary consuming time ..so fixed it too..
Contributor
There was a problem hiding this comment.
Ah ok that makes sense
Contributor
|
The code changes all look good to me. I mentioned the checks failing, but these ones can be ignored as they are not related. So I'm happy to approve. |
lauramccluskey1
approved these changes
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Oxford's scripts were too slow and taking hours to finish up , making it hard to bring any changes as everytime a lot of developer's time was going in executing it. More details on planio - 36735
Why?
For every record coming , check was being made if the file it belongs to is relevant to process under current handler or not.
How?
I have checked on first incoming record , if the file should be processed or not and return early if its not to be processed rather checking everytime for each record.
Testing ?
Locally tested via timing the script and here are the changes in timings -
Old -
BRCA script finishes at - Total time taken - 0 hours, 55 minutes, and 51 seconds.
CRC script finishes at - Total time taken - 0 hours, 40 minutes, and 19 seconds.
New times -
CRC - Total time taken - 0 hours, 10 minutes, and 38 seconds.
BRCA - Total time taken - 0 hours, 11 minutes, and 19 seconds.
Also compared the counts before and after changes and they stay the same.