Skip to content

Fixed regex to capture variants to avoid incompatible varpathclass and teststatus#105

Merged
shilpigoeldev merged 1 commit into
developfrom
feature/36724/oxford_status_varpathclass
Aug 16, 2024
Merged

Fixed regex to capture variants to avoid incompatible varpathclass and teststatus#105
shilpigoeldev merged 1 commit into
developfrom
feature/36724/oxford_status_varpathclass

Conversation

@shilpigoeldev

Copy link
Copy Markdown
Contributor

What?

During CASREF QA , Fiona and Jo have detected 5 incompatible teststatus and varpath class records for OXFORD (RTH) -

  • 1 record where teststatus is null and varpathclass is 4
  • 1 record where teststatus is null and varpathclass is 5
  • 3 records where teststatus is null and varpathclass is 3

Why?

Regex wasn't capturing the variants for these and hence not calling method to allocate the teststatus.

How?

Fixed the regex , also corrected my understanding with help from @NImeson of cdna variants which were rightly constructed but my code was putting them in exemptions considering malformed.

Testing?

Added test for impacted cases which are now rightly getting assigned teststatus along with varpathclass.
Also ran importer locally and could confirm counts are as expected and also query brings desired result -

select * from restricted_variants where teststatusis null and variantpathclass in (3,4,5);
 pseudo_id1 | pseudo_id2 | codingdnasequencechange | gene | proteinimpact | servicereportidentifier | authoriseddate | variantpathclass | moleculartestingtype | genetictestscope | teststatus | variantlocation | exonintroncodonnumber | provider | sequencevarianttype | original_filename | raw_record | molecular_dataid 
------------+------------+-------------------------+------+---------------+-------------------------+----------------+------------------+----------------------+------------------+------------+-----------------+-----------------------+----------+---------------------+-------------------+------------+------------------
(0 rows)

Comment thread lib/import/helpers/brca/providers/rth/constants.rb
@shilpigoeldev shilpigoeldev requested a review from NImeson August 16, 2024 09:50

@NImeson NImeson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@shilpigoeldev shilpigoeldev merged commit cc8ff6c into develop Aug 16, 2024
@shilpigoeldev shilpigoeldev deleted the feature/36724/oxford_status_varpathclass branch August 16, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants