Fixed regex to capture variants to avoid incompatible varpathclass and teststatus#105
Merged
Merged
Conversation
NImeson
reviewed
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
During CASREF QA , Fiona and Jo have detected 5 incompatible teststatus and varpath class records for OXFORD (RTH) -
Why?
Regex wasn't capturing the variants for these and hence not calling method to allocate the teststatus.
How?
Fixed the regex , also corrected my understanding with help from @NImeson of cdna variants which were rightly constructed but my code was putting them in exemptions considering malformed.
Testing?
Added test for impacted cases which are now rightly getting assigned teststatus along with varpathclass.
Also ran importer locally and could confirm counts are as expected and also query brings desired result -