Add ENV config points for config files, and make config writeable.#15
Conversation
This includes points for everything that we currently have, excluding SAML SSO which we know we do not need going forwards.
miles-smith
left a comment
miles-smith
left a comment
There was a problem hiding this comment.
This looks good to me; am happy to approve.
One question before I do - and this is probably my own short-sightedness - but is there a need to be able to short-circuit the svn calls to secondary/credentials repos? I'm not sure where Sam is currently with AWS deployment approaches, but in what I've seen previously (e.g. local deployment from/to an EC2 instance) the svn executable may not be present nor the network connectivity to the target repo if it were.
Allow email settings to be overridden using SMTP_USERNAME and SMTP_PASSWORD.
That's a great point. I've pushed additional changes, to support deployment without access to the internal repositories, and to allow SMTP credentials to be overridden with |
2 participants
This includes points for everything that we currently have, excluding SAML SSO which we know we do not need going forwards.