Gosh CRC varpathclass assignment , resolves #33988#17
Merged
Conversation
ollietulloch
approved these changes
Jul 19, 2023
ollietulloch
left a comment
ollietulloch
left a comment
Contributor
There was a problem hiding this comment.
There is quite a bit of rubocopping to do in the file but I think it's outside the scope of this commit, happy to approve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fix for varpathclass assigned to only abnormal gene in Gosh (RP4) colorectal records.
Updated test cases to make assertions not based on logging statements.
Why?
Analysts have observed that varpathclass is getting assigned to normal genes , so Fiona has asked to change the code to assign varpathclass only to abnormal genes as being done in Gosh BRCA handler. It resolves #Planio-33988.
Testing?
A new assertion has been added to test and also test file is updated to make assertions independent of logging statements.