Oxford CRC assign positive test status#21
Merged
Conversation
ollietulloch
approved these changes
Aug 1, 2023
ollietulloch
left a comment
ollietulloch
left a comment
Contributor
There was a problem hiding this comment.
Hi @shilpigoeldev,
As discussed, the regex is pretty "open", but having looked at the raw data, I can't see any way we could make it more strict.
Thanks,
Ollie
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
I have amended regex of chromomosomal and codingdnasequence to allow c.? and Inversion of exon to be captured as positive genotype.
Why?
Fiona after analysts suggestions has asked that for Oxford colorectal , above cases should be marked as positive.
More information can be found in planio ticket #34166
How?
Changes in the regex.
Testing?
Have added test case for above scenario.