Manchester crc#26
Merged
Merged
Conversation
bshand
approved these changes
Sep 6, 2023
bshand
left a comment
bshand
left a comment
Contributor
There was a problem hiding this comment.
It all looks good to me. (Much of the logic is too complicated for me to follow, but it looks sensible, and I assume it's working as expected.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manchester CRC has been restructured now , and also incorporated the updated lastest rules provided by Fiona. Counts have been shared and have gone through QA check and Fiona has approved. There are some rubocop issues, I have tried my best to reduce those but because of complex algorithms in handler and some existing generic code couldn't bring them to zero.