Skip to content

Bump gems to latest versions 2023-09#31

Merged
bshand merged 7 commits into
developfrom
feature/minitest_5_18_1
Sep 18, 2023
Merged

Bump gems to latest versions 2023-09#31
bshand merged 7 commits into
developfrom
feature/minitest_5_18_1

Conversation

@bshand

@bshand bshand commented Sep 3, 2023

Copy link
Copy Markdown
Contributor

This is a proactive bump of as many gems as possible to the latest versions.

A few have been held back at slightly earlier versions, e.g. minitest 5.19.0 depends on PR NHSDigital/ndr_dev_support#125 so I've bumped it to 5.18.1.

I haven't flagged the minitest issues explicitly in the code, because the next ndr_dev_support release should fix this, but I've locked a few other gems explicitly, where newer versions were causing problems.

I've updated this branch, now that minitest 5.19.0 is supported by ndr_dev_support 7.2.1.

@suezhou suezhou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bshand bshand merged commit f8dcdcf into develop Sep 18, 2023
@bshand bshand deleted the feature/minitest_5_18_1 branch September 18, 2023 09:19
samuelthampynhs pushed a commit that referenced this pull request Sep 28, 2023
---------

Co-authored-by: shilpigoel <shilpi.goel@phe.gov.uk>

Bump gems to latest versions 2023-09 (#31)

* # Bump mocha to 2.1.0

* # Bump delayed_job to 4.1.11

* # Bump webpacker to 5.4.4

* # Bump simplecov to 0.22.0

* # Bump minitest to 5.18.1

* # Rubocop boyscouting

* # Bump minitest to 5.19.0

Add argument checks and sample usage to BRCA and colorectal import scripts. (#36)

Fix

Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants