Feature/cambridge brca#33
Merged
Merged
Conversation
ollietulloch
requested changes
Sep 8, 2023
ollietulloch
left a comment
ollietulloch
left a comment
Contributor
There was a problem hiding this comment.
Thanks @lauramccluskey1
There are a couple of issues that could be addressed.
Contributor
|
Looks all good to me , we still have one rubocop issue of " Method has too many lines. [16/15]" but for readability of the method it should be OK to keep it together rather breaking further onto smaller calls. Thanks |
ollietulloch
approved these changes
Sep 8, 2023
shilpigoeldev
approved these changes
Sep 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cambridge importer updated for non pathogenic variants (if variantpathclass is 1 or 2, then test status should be 10). The variant counts from the cambridge importer have passed QA. cambridge_handler.rb and cambridge_handler_tests.rb have been run through rubocop. There was 1 error- process_fields function is too long- but this function is just calling lots of other functions so it was difficult to shorten. Unittests have been updated and run successfully.