importer fix for old st george hander#86
Merged
Conversation
ollietulloch
approved these changes
Jun 24, 2024
| end | ||
|
|
||
| test 'process_fields' do | ||
| e_batch = EBatch.create(original_filename: 'test_file', |
Contributor
There was a problem hiding this comment.
I'm assuming this e_batch isn't persisted, it'd be invalid with RJ7_2. e_batch.reload shows that it is persisted as part of handler.finalize.
Contributor
There was a problem hiding this comment.
Yes that's right ...Its because , we change the e_batch properties via handler using instance variable, So any change made there is reflected in e_batch as well and that gets persisted in database.. EBatch.last.provider also gives same thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
PR to fix issue with running two handlers for one provider (St George's BRCA).
How ?
Replacing the ebatch registry code and provider code before data is persisted in the database will permit two seperate handlers to be run for the same provider code.
Testing?
Added relevant test case for method.
Anything Else?