Few free provider codes fix#98
Merged
Merged
Conversation
ollietulloch
requested changes
Jul 24, 2024
ollietulloch
left a comment
ollietulloch
left a comment
Contributor
There was a problem hiding this comment.
Just a bit of DRYing up please :)
ollietulloch
approved these changes
Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fix values where there are over 100 identical records for free text coming in providercode field rather 3 or 5 letter org code.
How?
Added org code map to replace text provider code with org code provided by Fiona.
Testing?
Added relevant tests and ran importers locally to see genotype objects are getting right codes wherever applicable-