Moved the ci:all rake task invocation out of band#24
Merged
joshpencheon merged 4 commits intoOct 17, 2018
Conversation
…d clause for projects with no Gemfile
Contributor
Author
|
This PR could be squashed and merged. |
timgentry
added a commit
that referenced
this pull request
Oct 19, 2018
* # Added with_clean_rbenv and shelling out to bundle install with guard clause for projects with no Gemfile * # Additional guard clause to speed up bundle update with no Gemfile changes * # Added missing require * # discarding local changes e.g. as a result of migrations or bundle install
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI server used to invoke the
ci:allrake task from within the CI rake task, causing it to be brittle in the face of bundle and/or migration db schema changes.This is a breaking change as projects no longer need to discard their own changes or bundle install.