Skip to content
This repository was archived by the owner on Jul 24, 2022. It is now read-only.

Auto closing TcpClient#12

Merged
Maxwe11 merged 2 commits into
NModbus4:masterfrom
bilalovim:bim_branch
Mar 9, 2015
Merged

Auto closing TcpClient#12
Maxwe11 merged 2 commits into
NModbus4:masterfrom
bilalovim:bim_branch

Conversation

@bilalovim

Copy link
Copy Markdown

Added auto closing TcpClient and removing from _masters when it isn't active.

@Maxwe11

Maxwe11 commented Mar 6, 2015

Copy link
Copy Markdown
Member

In ModbusTcpSlave.Dispose(bool) after server stops also Stop and Dispose timer if it non null.
For addressing feedback - amend your commit.

private ModbusTcpSlave(byte unitId, TcpListener tcpListener, double timeInterval)
public static ModbusTcpSlave CreateTcp(byte unitId, TcpListener tcpListener, double timeInterval)

Rename SocketConnected -> IsSocketConnected

Add const TimeWaitResponse for using in method IsSocketConnected

Rename _timer_Elapsed -> OnTimer
Maxwe11 added a commit that referenced this pull request Mar 9, 2015
Added auto closing TcpClient and removing from _masters when it isn't active
@Maxwe11 Maxwe11 merged commit 1021887 into NModbus4:master Mar 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants