feat(gestures): add tap location getX() and getY() to double tap event data#8338
Merged
Conversation
vakrilov
suggested changes
Mar 6, 2020
Contributor
There was a problem hiding this comment.
Hey @MCurran16 - thanks for the PR!
Can you change the locationX and locationY properties to getX() and getY() methods to be consistent with TouchGestureEventData
MCurran16
changed the title
Contributor
|
test |
dtopuzov
approved these changes
Mar 11, 2020
This was referenced Apr 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
locationX/locationY are not included in the double tap gesture's event data
What is the new behavior?
locationX/locationY are included in the event data