script(1): Enable proper playback [-p] of curses sessions by 8vasu · Pull Request #14 · NetBSD/src

8vasu · 2020-08-01T07:11:54Z

The current manpage of script(1) says the following.

Certain interactive commands, such as vi(1), create garbage in the typescript file. The script utility works best with commands that do not manipulate the screen. The results are meant to emulate a hardcopy terminal.

script(1) is currently able to record [-r] curses sessions perfectly; only the playback functionality [-p] has the above limitation when the terminal is not in raw mode; this patch removes this restriction by appropriately setting terminal attributes.

8vasu · 2020-08-01T07:17:19Z

Additional notes:

To reproduce the problem, run in a terminal that is not in raw mode.
I used https://github.com/iiSeymour/game-of-life to reproduce the problem; authored by GitHub user iiSeymour, this, in the words of the author, is "a python implementation of Conway's Game of Life using the curses module with a small evolutionary twist"; it was written for Linux; therefore, one must call "python gol.py" on NetBSD to bypass the "#!".
I submitted a similar patch for "scriptreplay(1)" from util-linux; it has now been merged by the maintainer of the project.
I recently submitted a similar patch for FreeBSD script(1): https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=248377

8vasu · 2020-08-01T07:32:53Z

I have filed a PR that refers to this pull request: NetBSD Problem Report #55529.

8vasu · 2020-08-02T03:08:42Z

This has been committed. Closing.

usr.sbin/sysinst/disks.c: revision 1.46 Properly handle partitions that we were requested to mount but not newfs.

sys/dev/pci/if_rge.c: revision 1.25 sys/dev/pci/if_rgereg.h: revision 1.7 Update the Rx descriptor based on the vendor driver for Linux. This fixes a panic on RTL8125. Patch from OpenBSD if_rge.c r1.20, if_rgereg.h r1.8. Tested by msaitoh@n.o.

29 November 2023: Wouter - Tag for 4.8.0rc1. 28 November 2023: Wouter - Set up doc/RELNOTES for upcoming release. - Fix unit test kill_from_pidfile function for nonexistent files because the argument is evaluated before the test expression. - Fix rr-test to also convert the contents of the just written output file. - Fix test set to remove -f nsd.db and rm nsd.db commands. - Fix test set to remove difffile option. 27 November 2023: Jeroen - Fix #14: Set timeout to 3s when servicing remaining TCP connections. - Fix: Always instate write handler after reading queries from TCP. - Answer first query on connections accepted just before reload. 27 November 2023: Wouter - Merge #305: faster stats. Statistics can be gathered while a reload is in progress. 27 November 2023: Willem - Merge #302: Test package fixes. Correct Auxfiles, kill_from_pidfile function and fix drop_updates, rr-test and xfr_update tests. 1 November 2023: Jeroen - Remove on-disk database. 31 October 2023: Wouter - Merge #301: improve the logging of ixfr fallbacks to axfr. 30 October 2023: Jeroen - Fix processing of consolidated IXFRs. 30 October 2023: Wouter - Fix for interprocess communication to set quit sync command from main process explicitly. 3 October 2023: Wouter - Merge #281: Proxy protocol. An implementation of PROXYv2 for NSD. It can be configured with proxy-protocol-port: portnum with the port number of the interface on which proxy traffic is handled. The interface can support proxy traffic for UDP, TCP and TLS. 21 September 2023: Wouter - Merge #295: Update e-mail addresses, add ref to support contracts 31 August 2023: Wouter - Fix autoconf 2.69 warnings in configure. 14 July 2023: Wouter - Merge #287: Update nsd.conf.5.in. 11 July 2023: Wouter - Fix unused variable warning in unit test of udb. 22 June 2023: Wouter - Fix #284: dnstap_collector.c: SOCK_NONBLOCK is not available on Mac/Darwin. 7 June 2023: Wouter - Merge #282: Improve nsd.conf man page. - Fix unused but set variable warning. - Fix #283: Compile failure in remote.c when --disable-bind8-stats and --without-ssl are specified. 31 May 2023: Wouter - Add missing items to doc/RELNOTES. - Tag for 4.7.0rc1. It became release 4.7.0 on 7 june 2023. The code repository continues with 4.7.1. 30 May 2023: Jeroen - Fix #240: Prefix messages originating from verifier. - Fix #275: Drop unnecessary root server checks. 30 May 2023: Wouter - Next version is 4.7.0, instead of 4.6.2, because of the added features, like TLS for DNSTAP. - Fix unused variable warning in unit test, from clang compile. 24 May 2023: Wouter - For #279: Note that autoreconf -fi creates the configure script and also the needed auxiliary files, for autoconf 2.69 and 2.71. 4 May 2023: Wouter - Fix to remove unused whitespace from acx_nlnetlabs.m4 and config.h. 1 May 2023: Wouter - make depend. - Fix for build to run flex and bison before compiling code that needs the headers. 13 April 2023: Wouter - Fix cirrus script for submit to coverity scan to libtoolize the configure script components config.guess and config.sub. - Fix readme status badge links. 28 March 2023: Wouter - Fix #273: Large TXT record breaks AXFR. - Fix ixfr create from adding too many record types. 16 March 2023: Wouter - Fix include brackets for ssl.h include statements, instead of quotes. - Fix static analyzer warning about nsd_event_method initialization. 15 March 2023: Wouter - Dnstap tls code fixes. 14 March 2023: Wouter - Fix dnstap to not check socket path when using IP address. - dnstap over TLS, default enabled. Configured with the options dnstap-tls, dnstap-tls-server-name, dnstap-tls-cert-bundle, dnstap-tls-client-key-file and dnstap-tls-client-cert-file. - Fix to compile without ssl with dnstap-tls code. 9 March 2023: Wouter - Fix #271: DNSTAP over TCP, with dnstap-ip: "127.0.0.1@3333". - Fix to clean more memory on exit of dnstap collector. 23 February 2023: Wouter - Fix #270: reserved identifier violation. 20 February 2023: Wouter - Merge #269 from Fale: Add systemd service unit. 16 February 2023: Wouter - Fix #266: Fix build with --without-ssl. - Fix #267: Allow unencrypted local operation of nsd-control. - Fix for #267: neater variable definitions. 2 February 2023: Wouter - Merge #265: Fix C99 compatibility issue. 30 January 2023: Wouter - Merge #263: Add bash autocompletion script for nsd-control. - Fix for #262: More error logging for SSL read failures for zone transfers. 27 January 2023: Wouter - Fix #262: Zone(s) not synchronizing properly via TLS. - Fix ixfr_and_restart test to wait for processes to come to a stop. 26 January 2023: Wouter - Fix configure for -Wstrict-prototypes. 10 November 2022: Wouter - Tag for NSD 4.6.1, the repository continues with version 4.6.2. - Fix #239: -Wincompatible-pointer-types warning in remote.c. - Fix unit tests to succeed with --disable-bind8-stats. 1 November 2022: Wouter - Fixup for non-trailing newline lexer change warnings. - Update doc/RELNOTES for changes. - Fix ixfr_gone unit test to not use system default zone list file. - Fix credns tests for vm usage, and not use system default zone list file. - Fix verify tests to use more portable bash location in script. - Fix verify_again test to use ipv4 address for test. 1 November 2022: Tom - Add SVCB dohpath support 28 September 2022: Jeroen - Set ALPN "dot" token during connection establishment as per RFC9103 section 7.1 (Thanks Cesar Kuroiwa). 21 September 2022: Tom - Change zone parsing to accept non-trailing newline. 1 September 2022: Wouter - Merge #231 from moritzbuhl: Fix checking if nonblocking sockets work on OpenBSD. 19 August 2022: Wouter - Update cirrus build script for newer Ubuntu image, and FreeBSD build with libtoolize to install auxiliary files. - Update to clang 14 in cirrus build test on Ubuntu Jammy 22.04. 7 July 2022: Tom - Fix #212: Change commandline control actions to always log. 1 July 2022: Wouter - Fix static analyzer reports, fix wrong log print when skipping xfr, fix to print error on pipe read fail, and assert an xfr is in progress during packet checks.

sys/arch/amd64/conf/MICROVM: revision 1.4 sys/arch/i386/conf/MICROVM: revision 1.4 Add `+invtsc` to the QEMU command line example, this enables the invariant TSC feature, allowing the kernel to use CPUID 0x40000010 to read TSC and LAPIC frequencies from the host, thus avoiding the need for frequency calculation and gaining over 200ms in boot speed.

Enable proper playback [-p] of curses sessions

61325c9

8vasu closed this Aug 2, 2020

netbsd-srcmastr pushed a commit that referenced this pull request May 1, 2021

Pull up following revision(s) (requested by martin in ticket #14):

e34814a

usr.sbin/sysinst/disks.c: revision 1.46 Properly handle partitions that we were requested to mount but not newfs.

netbsd-srcmastr pushed a commit that referenced this pull request May 1, 2021

Tickets #8 and #14-#16.

e7b5912

netbsd-srcmastr pushed a commit that referenced this pull request Nov 8, 2021

Pull up following revision(s) (requested by martin in ticket #14):

79c5fd6

usr.sbin/sysinst/disks.c: revision 1.46 Properly handle partitions that we were requested to mount but not newfs.

netbsd-srcmastr pushed a commit that referenced this pull request Nov 8, 2021

Tickets #8 and #14-#16.

24dc226

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

script(1): Enable proper playback [-p] of curses sessions#14

script(1): Enable proper playback [-p] of curses sessions#14
8vasu wants to merge 1 commit into
NetBSD:trunkfrom
8vasu:script_curses

8vasu commented Aug 1, 2020

Uh oh!

8vasu commented Aug 1, 2020

Uh oh!

8vasu commented Aug 1, 2020

Uh oh!

8vasu commented Aug 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

8vasu commented Aug 1, 2020

Uh oh!

8vasu commented Aug 1, 2020

Uh oh!

8vasu commented Aug 1, 2020

Uh oh!

8vasu commented Aug 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant