Skip to content

gzip: Use fts_path instead of fts_name to get full path on messages#25

Closed
ricardobranco777 wants to merge 1 commit into
NetBSD:trunkfrom
ricardobranco777:gzip_path
Closed

gzip: Use fts_path instead of fts_name to get full path on messages#25
ricardobranco777 wants to merge 1 commit into
NetBSD:trunkfrom
ricardobranco777:gzip_path

Conversation

@ricardobranco777

Copy link
Copy Markdown

The handle_dir() function should pass fts_path and not fts_name because the latter is the basename(3). Because of this, not just verbose output but error messages as well are ambiguous when files with the same name exist.

To reproduce:

$ mkdir /tmp/x /tmp/y
$ cp /etc/services /tmp/x
$ cp /etc/services /tmp/y
$ chmod 000 /tmp/x/services
$ gzip -vr /tmp/x /tmp/y
gzip: can't open services: Permission denied
services:          86.1% -- replaced with services.gz

With patch:

gzip: can't open /tmp/x/services: Permission denied
/tmp/y/services:	   86.1% -- replaced with /tmp/y/services.gz

Fixed in FreeBSD: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=114470

rokuyama pushed a commit to IIJ-NetBSD/netbsd-src that referenced this pull request Jan 15, 2024
netbsd-srcmastr pushed a commit that referenced this pull request Jan 15, 2024
@ricardobranco777 ricardobranco777 deleted the gzip_path branch February 4, 2024 16:17
netbsd-srcmastr pushed a commit that referenced this pull request Sep 5, 2025
	sys/arch/arm/cortex/gicv3.c: revision 1.55
	sys/arch/arm/cortex/gicv3.c: revision 1.56

gicv3: Appease KUBSAN, otherwise NFC

gicv3: Some more left-shift v.s. int fixes
Suggested by msaitoh@, thanks!
netbsd-srcmastr pushed a commit that referenced this pull request Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant