Skip to content

Expose hook for reflective dispatch.#109

Merged
codefromthecrypt merged 1 commit into
masterfrom
adrian.expose-InvocationHandlerFactory
May 27, 2014
Merged

Expose hook for reflective dispatch.#109
codefromthecrypt merged 1 commit into
masterfrom
adrian.expose-InvocationHandlerFactory

Conversation

@codefromthecrypt

Copy link
Copy Markdown

This adds a single public type: InvocationHandlerFactory which should allow integration like rxjava and hystrix per #105.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was just me cleaning up verbose equals impl

@cloudbees-pull-request-builder

Copy link
Copy Markdown

feign-pull-requests #152 SUCCESS
This pull request looks good

@spencergibb

Copy link
Copy Markdown
Contributor

Looks good to me

@spencergibb

Copy link
Copy Markdown
Contributor

I've updated my project. All I had to do was change some imports and it worked just fine.

@codefromthecrypt

Copy link
Copy Markdown
Author

Great!

codefromthecrypt pushed a commit that referenced this pull request May 27, 2014
…actory

Expose hook for reflective dispatch.
@codefromthecrypt codefromthecrypt merged commit 9874399 into master May 27, 2014
@spencergibb

Copy link
Copy Markdown
Contributor

Is there a snapshot repository for feign?

@codefromthecrypt

Copy link
Copy Markdown
Author

@spencergibb it would be here, https://oss.sonatype.org/content/repositories/snapshots/com/netflix/feign/

but.. I suppose there's no jenkins job setup or running to publish it. Any chance the snapshot job can be run? @rspieldenner @allenxwang

@codefromthecrypt codefromthecrypt deleted the adrian.expose-InvocationHandlerFactory branch May 28, 2014 14:32
@spencergibb

Copy link
Copy Markdown
Contributor

I saw that there were no jars there and decided to ask :-)

@allenxwang

Copy link
Copy Markdown
Contributor

@adriancole I will try configure the snapshot (for master branch) to run on changes. I will need to make minor dependency changes because some old artifacts are no longer available to the snapshot build.

By the way, can we make build changes to feign-example-github and feign-example-wikipedia to compile against the latest sources, as opposed to the previous version of binaries?

@codefromthecrypt

Copy link
Copy Markdown
Author

Thanks, allen. So switching examples over works for me. Changes what we
optimize for (looking forward vs back).

velo pushed a commit that referenced this pull request Oct 8, 2024
…actory

Expose hook for reflective dispatch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants