Lower case headers in response and use TreeMap to allow case insensitive access#418
Merged
codefromthecrypt merged 1 commit intoJul 11, 2016
Conversation
| } | ||
|
|
||
| /** | ||
| * Map of header names to collection of values. This is a TreeMap which uses a case-insensitive |
There was a problem hiding this comment.
no need to talk about implementation (in case it one day changes), you can just say..
/** Returns a case-insensitive mapping of header names to their values. */
|
the change seems desirable. I made some style comments, but there's nothing concerning. |
Contributor
Author
|
Rebased this PR to resolve merge conflicts on the changelog. Would be nice to have this merged soon. Thanks again. |
| * Adds support for encoded query parameters in `@QueryMap` via `@QueryMap(encoded = true)` | ||
| * Keys in `Response.headers` are now lower-cased. This map is now case-insensitive with regards to keys, | ||
| and iterates in lexicographic order. | ||
| * This is a step towards supporting http2, as header names in http1 are treated as case-insensitive |
There was a problem hiding this comment.
even better than my suggestion. nice!
|
Thanks to you! |
codefromthecrypt
pushed a commit
that referenced
this pull request
Jul 14, 2016
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the discussion on https://gitter.im/Netflix/feign