Add a method metadata property, in order to control whether need to c…#583
Add a method metadata property, in order to control whether need to c…#583dyc87112 wants to merge 2 commits into
Conversation
…heck body is null
…heck body is null
|
Hey, why don't you overload the method, creating a new one without the body. That would accomplish it without passing nulls forward. I see a point on supporting Lemme know what you think. |
|
@dyc87112 There are no test cases included in this PR. Could you please add some to ensure that we have coverage? |
kdavisk6
added
the
waiting for feedback
|
ping? How would you intend for the |
|
2 months no feedback. Closing, please re-open if necessary |
|
Well, I'm not sure what was the goal on this pr. You would need the author back on the discussion. |
|
Hi, @dyc87112 @velo @kdavisk6 I would like to reopen the discussion of this PR. This kind of functionality would be useful for us to fix this issue, also discussed here. I see the PR was closed due to lack of tests and feedback. I can take it over and add tests if you are fine with adding this feature. |
|
Lemme see if I got it correctly. Spring has an annotation So, you looking for a mechanism to tell feign to not process a parameter?! Saw many comments on the ticket and didn't read them all. |
|
Can please create a new issue referencing your issue? I'd like to move the discussion there so it does not get lost. |
|
@kdavisk6 |
|
We need to differentiate NULL body, from absent Having another boolean flag is not healthy they will explode out of control someday |
7 participants
hello, this pull request is to make the request Body to be an optional properties.
Current version, if the body is null, feign will return error message “Body parameter %s was null”.
If this PR can be accept. Then I can fix another issue in Spring Cloud Feign：https://github.com/spring-cloud/spring-cloud-netflix/issues/1047
Thanks.