Thank you for your PR. Can you please create an issue explaining what problem you are having and what the expected outcome of this change should be. That will help provide the context we need to review this properly.

I've created this issue #801
should i push another PR ?

No, that won't be necessary.

What I would really like to see was an unit test =)

Yes, you'are absolutely right. I'll try to add some 👍

Would also be nice to have this rebased with master

@herrhilmi If you could add some tests, I think this PR is in good shape to be accepted.

Ok, I will try to fix this asap

Thinking about this more, I suggest that, instead of modifying the existing default client, we provide a a ProxyClient implementation, allowing users to choose which targets should use a proxy and which should not.

Any thoughts?

Thinking about this more, I suggest that, instead of modifying the existing default client, we provide a a ProxyClient implementation, allowing users to choose which targets should use a proxy and which should not.

There is a Default and a Proxied implementation.

Do you think that covers your request?

The only thing I'm really missing is some testing.

@velo

My concern is that Default was changed to accommodate Proxy by updating the convertAndSend method to accept a Proxy. I would prefer that the Proxy Client be separated more. For example:

final boolean useProxy = proxy != null;
final URL url = new URL(request.url());  
final HttpURLConnection connection =  (HttpURLConnection) (useProxy ? url.openConnection(proxy) : url.openConnection());

is in Default, creating a dependency on the proxy flag for all cases. I would prefer this logic be isolated into the Proxy client. To be even more specific, here is what I would like to see here:

• Revert changes to Default client
• Isolate Proxy usage to the Proxy client only
• Unit Tests for the Proxy client added.

Replaced by #1045