Fix bug at installation process#69
Merged
sql-williamd merged 2 commits intoMar 15, 2018
Merged
Conversation
added 2 commits
March 15, 2018 11:15
…object_catalog to uninstall script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to install OQS into a database with a middle hyphen in the name like 'database-DEV' and if kept failing due to the fact that on script "install_service_broker.sql" on line 168 the brackets were missing. Added the brackets and the problem was solved. Also noticed that while it failed the uninstall script also had a missing drop statement for the view "oqs.object_catalog" and it also failed to uninstall. I fixed that script also to consider the missing drop view sentence.