Added authentication using email test case by vaibhavsingh97 · Pull Request #180 · OpenSourceHelpCommunity/OpenSourceHelpCommunity.github.io

vaibhavsingh97 · 2017-10-22T19:11:11Z

Checklist

My branch is up-to-date with the upstream develop branch.
I have added necessary documentation (if appropriate).

Which issue does this PR fix?: fixes #179

houndci-bot · 2017-10-22T19:11:15Z

+        self.assertEqual(response.status_code, 200)
+
+class EmailLoginBackendTests(TestCase):
+


blank line contains whitespace

houndci-bot · 2017-10-22T19:11:15Z

+        response = self.client.get(reverse("account_reset_password"))
+        self.assertEqual(response.status_code, 200)
+
+class EmailLoginBackendTests(TestCase):


expected 2 blank lines, found 1

houndci-bot · 2017-10-22T19:11:16Z

+        self.assertEqual(response.status_code, 302)
+
+class PasswordResetViewTest(TestCase):
+


blank line contains whitespace

houndci-bot · 2017-10-22T19:11:16Z

+        response = self.client.get(reverse("account_change_password"))
+        self.assertEqual(response.status_code, 302)
+
+class PasswordResetViewTest(TestCase):


expected 2 blank lines, found 1

houndci-bot · 2017-10-22T19:11:16Z

+        response = self.client.get(reverse("account_signup"))
+        self.assertEqual(response.status_code, 200)
+
+class PasswordChangeViewTest(TestCase):


expected 2 blank lines, found 1

houndci-bot · 2017-10-22T19:11:16Z

+        self.assertEqual(response.status_code, 200)
+
+class RegisterViewTest(TestCase):
+


blank line contains whitespace

houndci-bot · 2017-10-22T19:11:16Z

+        response = self.client.get(reverse("account_login"))
+        self.assertEqual(response.status_code, 200)
+
+class RegisterViewTest(TestCase):


expected 2 blank lines, found 1

houndci-bot · 2017-10-22T19:11:16Z

+from __future__ import unicode_literals
+
+from django.contrib.auth.models import User
+from django.test import SimpleTestCase, TestCase


'django.test.SimpleTestCase' imported but unused

coveralls · 2017-10-22T19:16:23Z

Coverage decreased (-22.6%) to 45.005% when pulling 5fd2ace on vaibhavsingh97:Patch4/addAutenticationTestCase into f01f550 on OpenSourceHelpCommunity:predev.

vaibhavsingh97 · 2017-10-22T19:46:08Z

@tapasweni-pathak How could i include authentication in travis?

coveralls · 2017-10-22T19:46:35Z

Coverage remained the same at 67.619% when pulling 0b90bf2 on vaibhavsingh97:Patch4/addAutenticationTestCase into f01f550 on OpenSourceHelpCommunity:predev.

coveralls · 2017-10-22T19:46:50Z

Coverage remained the same at 67.619% when pulling 0b90bf2 on vaibhavsingh97:Patch4/addAutenticationTestCase into f01f550 on OpenSourceHelpCommunity:predev.

coveralls · 2017-10-23T02:21:06Z

Coverage increased (+10.2%) to 77.838% when pulling de90d18 on vaibhavsingh97:Patch4/addAutenticationTestCase into f01f550 on OpenSourceHelpCommunity:predev.

coveralls · 2017-10-23T02:23:46Z

Coverage increased (+10.2%) to 77.838% when pulling 2646934 on vaibhavsingh97:Patch4/addAutenticationTestCase into f01f550 on OpenSourceHelpCommunity:predev.

tapaswenipathak · 2017-10-23T13:58:05Z


 script:
-  - coverage run --source='main' manage.py test --verbosity 2
+  - coverage run --source=main,authentication  manage.py test --verbosity 2


What happens if you say coverage run oshc/manage.py test?

Then our coverage decreased to 42% because Travis makes virtual environment and test.py only covers some file

vaibhavsingh97 · 2017-10-25T12:41:38Z

@tapasweni-pathak please review and merge

tapaswenipathak

We won't be going ahead with writing the app names specifically.
coverage run --source='.' manage.py test runs good on all apps but also on where we don't want it to.

Will merge this with a .coveragerc and including the excludes of not important files/directories; in process here.

vaibhavsingh97 · 2017-10-29T17:47:12Z

@tapasweni-pathak So i will push .coveragerc 👍

coveralls · 2017-10-29T17:57:30Z

Coverage increased (+9.3%) to 76.884% when pulling 5170211 on vaibhavsingh97:Patch4/addAutenticationTestCase into f01f550 on OpenSourceHelpCommunity:predev.

coveralls · 2017-10-29T18:00:22Z

Coverage decreased (-10.5%) to 57.104% when pulling d4dfa9d on vaibhavsingh97:Patch4/addAutenticationTestCase into f01f550 on OpenSourceHelpCommunity:predev.

vaibhavsingh97 · 2017-10-29T18:02:02Z

@tapasweni-pathak Coverage reduced as it's checking the whole code

jarifibrahim · 2017-12-18T19:36:16Z

@vaibhavsingh97 Ping! Are you still working on this?

vaibhavsingh97 added the status: Needs Review label Oct 22, 2017

houndci-bot reviewed Oct 22, 2017

View reviewed changes

OpenSourceHelpCommunity deleted a comment from coveralls Oct 22, 2017

vaibhavsingh97 force-pushed the Patch4/addAutenticationTestCase branch from 9449f5f to 0b90bf2 Compare October 22, 2017 19:45

vaibhavsingh97 requested a review from tapaswenipathak October 23, 2017 02:22

Changed travis config

2646934

vaibhavsingh97 force-pushed the Patch4/addAutenticationTestCase branch from de90d18 to 2646934 Compare October 23, 2017 02:22

tapaswenipathak reviewed Oct 23, 2017

View reviewed changes

tapaswenipathak requested changes Oct 28, 2017

View reviewed changes

Added coveragerc file

5170211

changed travis ci config

d4dfa9d

tapaswenipathak removed the status: Needs Review label Nov 18, 2017

tapaswenipathak approved these changes Dec 16, 2018

View reviewed changes

tapaswenipathak merged commit d833029 into OpenSourceHelpCommunity:predev Dec 16, 2018

vaibhavsingh97 deleted the Patch4/addAutenticationTestCase branch December 17, 2018 09:02

		self.assertEqual(response.status_code, 200)

		class EmailLoginBackendTests(TestCase):

		self.assertEqual(response.status_code, 302)

		class PasswordResetViewTest(TestCase):

		self.assertEqual(response.status_code, 200)

		class RegisterViewTest(TestCase):

Uh oh!

Conversation

vaibhavsingh97 commented Oct 22, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Oct 22, 2017

Uh oh!

vaibhavsingh97 commented Oct 22, 2017

Uh oh!

coveralls commented Oct 22, 2017

Uh oh!

coveralls commented Oct 22, 2017

Uh oh!

coveralls commented Oct 23, 2017

Uh oh!

coveralls commented Oct 23, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vaibhavsingh97 commented Oct 25, 2017

Uh oh!

tapaswenipathak left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vaibhavsingh97 commented Oct 29, 2017

Uh oh!

coveralls commented Oct 29, 2017

Uh oh!

coveralls commented Oct 29, 2017

Uh oh!

vaibhavsingh97 commented Oct 29, 2017

Uh oh!

jarifibrahim commented Dec 18, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tapaswenipathak left a comment •

edited

Loading