[WIP] Added test case for Chat sessstion View, Contest Form by vaibhavsingh97 · Pull Request #182 · OpenSourceHelpCommunity/OpenSourceHelpCommunity.github.io

vaibhavsingh97 · 2017-10-23T17:21:56Z

Checklist

My branch is up-to-date with the upstream develop branch.
I have added necessary documentation (if appropriate).

Which issue does this PR fix?: fixes #179

houndci-bot · 2017-10-23T17:22:03Z

+#         self.assertTrue(form.is_valid())
+
+#     def test_ContestForm_invalid(self):
+#         form = Contest(data={'name': '112', 'link': 'google.com/', 'description': 'This is a sample description', 'start_date': '9999-99-99', 'end_date': 'csdd-dd-dd', 'approved': 'True'})


line too long (190 > 79 characters)

houndci-bot · 2017-10-23T17:22:04Z

+# class ContestFormTest(TestCase):
+
+#     def test_ContestForm_valid(self):
+#         form = Contest(data = {'name': 'oshc', 'link': 'http://google.com/', 'description': 'This is a sample description', 'start_date': '2014-04-03', 'end_date': '2014-04-04', 'approved': 'True'})


line too long (200 > 79 characters)

houndci-bot · 2017-10-23T17:22:04Z

+class ContestCreateValidation(TestCase):
+    def test_contest_create(self):
+        c = Client()
+        response = c.post('/contest_new/', {'name': 'oshc', 'link': 'http://google.com/', 'description': 'This is a sample description', 'start_date': '2014-04-03', 'end_date': '2014-04-04', 'approved': 'True'})


line too long (211 > 79 characters)

houndci-bot · 2017-10-23T17:22:04Z

+class ContestCreateTestCase(TestCase):
+    def setUp(self):
+        Contest.objects.create(name="oshc", link="http://google.com/", description="This is a sample description",
+                               start_date="2014-04-03", end_date="2014-04-04", approved=True)


line too long (93 > 79 characters)

houndci-bot · 2017-10-23T17:22:04Z

+
+class ContestCreateTestCase(TestCase):
+    def setUp(self):
+        Contest.objects.create(name="oshc", link="http://google.com/", description="This is a sample description",


line too long (114 > 79 characters)

houndci-bot · 2017-10-23T17:22:04Z

+
+    # def test_start_date(self):
+    #     timestamp =datetime.date.today()
+    #     ContestStartDate = chatSession.objects.get(start_date=datetime.datetime.fromtimestamp(timestamp, timezone.utc))


line too long (121 > 79 characters)

houndci-bot · 2017-10-23T17:22:04Z

+    def setUp(self):
+        timestamp = datetime.date.today()
+        chatSession.objects.create(title="oshc-session", profile_name="test_name", profile_url="http://google.com/", description="This is a sample description",
+                                   start_date=datetime.date.today(), end_date=datetime.date.today() + datetime.timedelta(days=1), register_url="http://google.com/")


line too long (164 > 79 characters)

houndci-bot · 2017-10-23T17:22:04Z

+class ChatSessionCreateTestCase(TestCase):
+    def setUp(self):
+        timestamp = datetime.date.today()
+        chatSession.objects.create(title="oshc-session", profile_name="test_name", profile_url="http://google.com/", description="This is a sample description",


line too long (160 > 79 characters)

houndci-bot · 2017-10-23T17:22:05Z

+
+class ChatSessionCreateTestCase(TestCase):
+    def setUp(self):
+        timestamp = datetime.date.today()


local variable 'timestamp' is assigned to but never used

houndci-bot · 2017-10-23T17:22:05Z

 from django.urls import reverse
+from main.models import Contest, chatSession
+import datetime
+from django.utils import timezone


'django.utils.timezone' imported but unused

coveralls · 2017-10-23T17:23:34Z

Coverage increased (+15.06%) to 82.684% when pulling 383291d on vaibhavsingh97:Patch5/addTestCase into f01f550 on OpenSourceHelpCommunity:predev.

coveralls · 2017-10-23T17:27:36Z

Coverage increased (+10.5%) to 78.146% when pulling b181723 on vaibhavsingh97:Patch5/addTestCase into f01f550 on OpenSourceHelpCommunity:predev.

tapaswenipathak

Great!

README update to run test

I cleaned up few things on this. When I say python3 oshc/manage.py test, it doesn't run the test. If I say python3 manage.py test after cd into oshc, it works! also if I say python3 oshc/manage.py test <app_name> it works. 🤔 Did you try this out, do you have a good read for this?

cc @jarifibrahim.

vaibhavsingh97 · 2017-10-28T02:58:06Z

@tapasweni-pathak This PR still has issues so please leave it for a moment

tapaswenipathak · 2017-10-28T03:29:08Z

What issues? 🤔 I am in the process of fixing this coverage part and not specifying all apps.

vaibhavsingh97 · 2017-10-28T03:50:11Z

@tapasweni-pathak issue with ChatSessionCreateTestCase

houndci-bot · 2017-11-06T18:42:13Z

+        self.start_date = timezone.make_aware(datetime.datetime(2017, 11, 6, 12, 10, 5))
+        self.end_date = timezone.make_aware(datetime.datetime(2017, 12, 15, 22, 45, 50))
+        chatSession.objects.create(title="oshc-session", profile_name="test_name", profile_url="http://google.com/", description="This is a sample description",
+                                   start_date=self.start_date, end_date=self.end_date, register_url="http://google.com/")


line too long (121 > 79 characters)

houndci-bot · 2017-11-06T18:42:13Z

+    def setUp(self):
+        self.start_date = timezone.make_aware(datetime.datetime(2017, 11, 6, 12, 10, 5))
+        self.end_date = timezone.make_aware(datetime.datetime(2017, 12, 15, 22, 45, 50))
+        chatSession.objects.create(title="oshc-session", profile_name="test_name", profile_url="http://google.com/", description="This is a sample description",


line too long (160 > 79 characters)

houndci-bot · 2017-11-06T18:42:13Z

+class ChatSessionCreateTestCase(TestCase):
+    def setUp(self):
+        self.start_date = timezone.make_aware(datetime.datetime(2017, 11, 6, 12, 10, 5))
+        self.end_date = timezone.make_aware(datetime.datetime(2017, 12, 15, 22, 45, 50))


line too long (88 > 79 characters)

houndci-bot · 2017-11-06T18:42:13Z

+
+class ChatSessionCreateTestCase(TestCase):
+    def setUp(self):
+        self.start_date = timezone.make_aware(datetime.datetime(2017, 11, 6, 12, 10, 5))


line too long (88 > 79 characters)

coveralls · 2017-11-06T18:43:44Z

Coverage increased (+14.9%) to 82.558% when pulling a1a4586 on vaibhavsingh97:Patch5/addTestCase into f01f550 on OpenSourceHelpCommunity:predev.

houndci-bot reviewed Oct 23, 2017

View reviewed changes

Added test case for contest form, chat session form

b181723

vaibhavsingh97 force-pushed the Patch5/addTestCase branch from 383291d to b181723 Compare October 23, 2017 17:25

vaibhavsingh97 added the status: Needs Review label Oct 23, 2017

tapaswenipathak approved these changes Oct 28, 2017

View reviewed changes

Fixed problem with test case

a1a4586

houndci-bot reviewed Nov 6, 2017

View reviewed changes

tapaswenipathak removed the status: Needs Review label Nov 18, 2017

tapaswenipathak merged commit ee7a4ad into OpenSourceHelpCommunity:predev Dec 16, 2018

vaibhavsingh97 deleted the Patch5/addTestCase branch December 17, 2018 09:01

Uh oh!

Conversation

vaibhavsingh97 commented Oct 23, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Oct 23, 2017

Uh oh!

coveralls commented Oct 23, 2017

Uh oh!

tapaswenipathak left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vaibhavsingh97 commented Oct 28, 2017

Uh oh!

tapaswenipathak commented Oct 28, 2017

Uh oh!

vaibhavsingh97 commented Oct 28, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Nov 6, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tapaswenipathak left a comment •

edited

Loading