Skip to content

move contact from header to footer #211#214

Merged
vaibhavsingh97 merged 1 commit into
OpenSourceHelpCommunity:predevfrom
alagram:move-contact-to-footer
Dec 25, 2017
Merged

move contact from header to footer #211#214
vaibhavsingh97 merged 1 commit into
OpenSourceHelpCommunity:predevfrom
alagram:move-contact-to-footer

Conversation

@alagram

@alagram alagram commented Dec 25, 2017

Copy link
Copy Markdown
Contributor

Checklist

  • My branch is up-to-date with the upstream develop branch.
  • I have added necessary documentation (if appropriate).

Which issue does this PR fix?: fixes #

Moved Contact from header to footer (Fixes #211)

Why do we need this PR?:

Because we want to move Contact from header to footer

Demo (optional):

Click on the envelope icon in the footer

Testing instructions:

None.

TODOs (if any):

A picture of a cute animal (not mandatory but encouraged):

enhanced-7725-1432671840-23

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 72.269% when pulling 88a4b4d on alagram:move-contact-to-footer into 7922fee on OpenSourceHelpCommunity:predev.

@anubhakushwaha anubhakushwaha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @alagram

@alagram

alagram commented Dec 25, 2017

Copy link
Copy Markdown
Contributor Author

@anubhakushwaha thanks! my first open source contribution 😃

@vaibhavsingh97 vaibhavsingh97 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 🚀

@vaibhavsingh97 vaibhavsingh97 merged commit ea6096f into OpenSourceHelpCommunity:predev Dec 25, 2017
@alagram alagram deleted the move-contact-to-footer branch December 25, 2017 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move Contact from header to footer

4 participants