Attempt to make it responsive#217
Conversation
|
@tapasweni-pathak @jarifibrahim I have attempted at making it responsive, please let me know if you know another way of doing it better. Please review. |
|
@anubhakushwaha Can you deploy somewhere and give us the live demo link |
|
@vaibhavsingh97 You could just run do a |
jarifibrahim
left a comment
jarifibrahim
left a comment
There was a problem hiding this comment.
Awesome work @anubhakushwaha . Thanks for the PR :)
There was a problem hiding this comment.
..and knew the magic of using % or em instead of specifying px. Great you picked % over em. 👍 I checked off one todo from here too. 🎉
You might want to try it on bigger screens too, the odd child's triangle will move away/extra padding from the rectangle. Let me know if you have questions for this or I'll take care of this before merging.
|
^ 🐼 😄 |
|
@tapasweni-pathak Sure, will update you on this. |
anubhakushwaha
force-pushed
the
makeResponsive
branch
from
d709b62 to
16458ca
Compare
|
@tapasweni-pathak I tested by zooming in the screen and it works well there as well as the |
|
👋 @anubhakushwaha, can you try with zooming out? Edit: One extra 👀 I see this issue on my localhost but not with our live urls. 😕 |
|
For some reason I only see it on different browsers in localhost and not on heroku on different browsers. Can someone please check it on how does it look on IE? Merging this, thanks for the work @anubhakushwaha 🎉. |
|
By the way you event made your commit message as |
5 participants
Checklist
pre-devbranch.Which issue does this PR fix?: fix partially #207
Brief description of what this PR does.
Attempts to make the web page responsive, this can be achieved by setting the element sizes in percentages rather than pixels as mentioned in this post
If relevant, please include a screenshot.
Different screen sizes
A picture of a cute animal (not mandatory but encouraged):
